Merge pull request #461 from thunze/masked-and-hidden

Create GitLab CI/CD variables with visibility masked and hidden on init

Author: zyzzyxdonta

src/hermes/commands/init/base.py

@@ -599,13 +599,13 @@ def configure_gitlab(self) -> None:
                     self.git_remote_url + "/-/settings/ci_cd", "project's ci settings")
             ))
             sc.echo("Then, add that token as variable with key HERMES_PUSH_TOKEN.")
-            sc.echo("(For your safety, you should set the visibility to 'Masked'.)")
+            sc.echo("(For your safety, you should set the visibility to 'Masked and hidden'.)")
             sc.press_enter_to_continue()
             sc.echo("Next, add the {} token{} as variable with key ZENODO_TOKEN.".format(
                 self.deposit_platform.name,
                 f" ({self.tokens[self.deposit_platform]})" if self.tokens[self.deposit_platform] else ""
             ))
-            sc.echo("(For your safety, you should set the visibility to 'Masked'.)")
+            sc.echo("(For your safety, you should set the visibility to 'Masked and hidden'.)")
             sc.press_enter_to_continue()
 
     def choose_deposit_platform(self) -> None:

src/hermes/commands/init/util/connect_gitlab.py

@@ -120,7 +120,14 @@ def create_variable(self, key: str, value, description: str = "") -> bool:
         sc.debug_info(delete_status=delete_response.status_code, delete_response=delete_response.text)
         # Then create a new variable
         create_url = urljoin(self.api_url, f"projects/{self.project_id}/variables")
-        data = {"key": key, "value": value, "masked": True, "raw": True, "description": description}
+        data = {
+            "key": key,
+            "value": value,
+            "masked": True,
+            "masked_and_hidden": True,
+            "raw": True,
+            "description": description,
+        }
         response = requests.post(create_url, headers=headers, json=data)
         if response.status_code == 201:
             desc = f" ({description})" if description else ""