Skip to content

Commit f7c1ada

Browse files
authored
Merge pull request #133 from sohobloo/revert-131-renderButtonTextFix
Revert "Possible Fix for renderButtonText Not Working"
2 parents a1c85b9 + 398108f commit f7c1ada

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

components/ModalDropdown.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,7 @@ export default class ModalDropdown extends Component {
8585
}
8686

8787
componentWillReceiveProps(nextProps) {
88-
let buttonText = this.state.buttonText;
89-
if (this._nextValue !== null) {
90-
buttonText = nextProps.renderButtonText && nextProps.renderButtonText(this._nextValue) || this._nextValue.toString();
91-
}
88+
let buttonText = this._nextValue == null ? this.state.buttonText : this._nextValue.toString();
9289
let selectedIndex = this._nextIndex == null ? this.state.selectedIndex : this._nextIndex;
9390
if (selectedIndex < 0) {
9491
selectedIndex = nextProps.defaultIndex;
@@ -362,8 +359,12 @@ export default class ModalDropdown extends Component {
362359
this._nextIndex = rowID;
363360
this.setState({
364361
buttonText: renderButtonText && renderButtonText(rowData) || rowData.toString(),
365-
selectedIndex: rowID,
366-
showDropdown: !(!onDropdownWillHide || onDropdownWillHide() !== false)
362+
selectedIndex: rowID
363+
});
364+
}
365+
if (!onDropdownWillHide || onDropdownWillHide() !== false) {
366+
this.setState({
367+
showDropdown: false
367368
});
368369
}
369370
}

0 commit comments

Comments
 (0)