Skip to content

Commit fed5c7f

Browse files
committed
Fix a bug in github: ...
(introduced with `0.34.0` / f63eb19)
1 parent f455b78 commit fed5c7f

File tree

5 files changed

+13
-11
lines changed

5 files changed

+13
-11
lines changed

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
## Changes in 0.34.0
1+
## Changes in 0.34.1
2+
- Fix a bug in `github: ...` introduced with `0.34.0`
3+
(f63eb19b956517b4dd8e28dc5785be5889a99298)
4+
5+
## Changes in 0.34.0 (deprecated)
26
- Use `PreferNoHash` as default `GenerateHashStrategy`
37
- Add support for library `visibility` (see #382)
48
- Reject URLs for `github`

hpack.cabal

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
cabal-version: 1.12
22

3-
-- This file has been generated from package.yaml by hpack version 0.33.0.
3+
-- This file has been generated from package.yaml by hpack version 0.33.1.
44
--
55
-- see: https://github.com/sol/hpack
6-
--
7-
-- hash: 12b7d6619eff1d32190bac55f5a9d29fc4732f7475eb5e450effd690c9f53964
86

97
name: hpack
10-
version: 0.34.0
8+
version: 0.34.1
119
synopsis: A modern format for Haskell packages
1210
description: See README at <https://github.com/sol/hpack#readme>
1311
category: Development

package.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: hpack
2-
version: 0.34.0
2+
version: 0.34.1
33
synopsis: A modern format for Haskell packages
44
description: See README at <https://github.com/sol/hpack#readme>
55
maintainer: Simon Hengel <sol@typeful.net>

src/Hpack/Config.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1166,7 +1166,7 @@ toPackage_ dir (Product g PackageConfig{..}) = do
11661166
github = toSourceRepository <$> packageConfigGithub
11671167
where
11681168
toSourceRepository :: GitHub -> SourceRepository
1169-
toSourceRepository (GitHub repo owner subdir) = SourceRepository (githubBaseUrl ++ owner ++ "/" ++ repo) subdir
1169+
toSourceRepository (GitHub owner repo subdir) = SourceRepository (githubBaseUrl ++ owner ++ "/" ++ repo) subdir
11701170

11711171
homepage :: Maybe String
11721172
homepage = case packageConfigHomepage of

test/EndToEndSpec.hs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,13 @@ spec = around_ (inTempDirectoryNamed "foo") $ do
111111
describe "github" $ do
112112
it "accepts owner/repo" $ do
113113
[i|
114-
github: hspec/hspec
114+
github: sol/hpack
115115
|] `shouldRenderTo` package [i|
116-
homepage: https://github.com/hspec/hspec#readme
117-
bug-reports: https://github.com/hspec/hspec/issues
116+
homepage: https://github.com/sol/hpack#readme
117+
bug-reports: https://github.com/sol/hpack/issues
118118
source-repository head
119119
type: git
120-
location: https://github.com/hspec/hspec
120+
location: https://github.com/sol/hpack
121121
|]
122122

123123
it "accepts owner/repo/path" $ do

0 commit comments

Comments
 (0)