fix: use manufacturer model name as model id (#178)

<img width="269" height="129" alt="Bildschirmfoto 2026-01-10 um 21 56
13"
src="https://github.com/user-attachments/assets/c2a1c7a5-a7cc-41bd-a322-e3ad479c4219"
/>

Author: CFenner

custom_components/solakon_one/const.py

@@ -8,6 +8,8 @@
 
 CONF_DEVICE_ID: Final = "slave_id"
 
+DEFAULT_MANUFACTURER: Final = "Solakon"
+DEFAULT_MODEL: Final = "ONE"
 DEFAULT_NAME: Final = "Solakon ONE"
 DEFAULT_PORT: Final = 502
 DEFAULT_DEVICE_ID: Final = 1

custom_components/solakon_one/entity.py

@@ -4,7 +4,7 @@
 from homeassistant.helpers.entity import Entity
 from homeassistant.helpers.update_coordinator import CoordinatorEntity
 
-from .const import DOMAIN
+from .const import DEFAULT_MANUFACTURER, DEFAULT_MODEL, DEFAULT_NAME, DOMAIN
 from .types import SolakonConfigEntry
 
 
@@ -29,9 +29,10 @@ def __init__(
 
         self._attr_device_info = DeviceInfo(
             identifiers={(DOMAIN, self._config_entry.entry_id)},
-            name=self._config_entry.data.get("name", "Solakon ONE"),
-            manufacturer=device_info.get("manufacturer", "Solakon"),
-            model=device_info.get("model", "One"),
+            name=self._config_entry.data.get("name", DEFAULT_NAME),
+            manufacturer=DEFAULT_MANUFACTURER,
+            model=DEFAULT_MODEL,
+            model_id=device_info.get("model"),
             sw_version=device_info.get("version"),
             serial_number=device_info.get("serial_number"),
         )

custom_components/solakon_one/modbus.py

@@ -13,7 +13,14 @@
 from homeassistant.const import CONF_HOST, CONF_PORT, CONF_SCAN_INTERVAL
 from homeassistant.core import HomeAssistant
 
-from .const import CONF_DEVICE_ID, DEFAULT_DEVICE_ID, DEFAULT_SCAN_INTERVAL, REGISTERS
+from .const import (
+    CONF_DEVICE_ID,
+    DEFAULT_DEVICE_ID,
+    DEFAULT_MANUFACTURER,
+    DEFAULT_NAME,
+    DEFAULT_SCAN_INTERVAL,
+    REGISTERS,
+)
 
 _LOGGER = logging.getLogger(__name__)
 
@@ -142,12 +149,11 @@ async def async_get_device_info(self) -> dict[str, Any]:
 
             if not self._client or not self.connected:
                 return {
-                    "manufacturer": "Solakon",
-                    "model": "Solakon ONE",
-                    "name": "Solakon ONE",
+                    "manufacturer": DEFAULT_MANUFACTURER,
+                    "name": DEFAULT_NAME,
                 }
 
-            model_name = "Solakon ONE"
+            model_name = None
             serial_number = None
 
             try:
@@ -160,28 +166,25 @@ async def async_get_device_info(self) -> dict[str, Any]:
                 )
 
                 if not model_result.isError():
-                    tmp_name = convert_string(model_result.registers)
-                    if tmp_name is not None:
-                        model_name = tmp_name
+                    model_name = convert_string(model_result.registers)
                 if not serial_result.isError():
                     serial_number = convert_string(serial_result.registers)
 
             except Exception as e:
                 _LOGGER.debug(f"Device info read error: {e}")
 
             return {
-                "manufacturer": "Solakon",
+                "manufacturer": DEFAULT_MANUFACTURER,
                 "model": model_name,
-                "name": model_name,
+                "name": model_name or DEFAULT_NAME,
                 "serial_number": serial_number,
             }
 
         except Exception as err:
             _LOGGER.error(f"Failed to get device info: {err}")
             return {
-                "manufacturer": "Solakon",
-                "model": "Solakon ONE",
-                "name": "Solakon ONE",
+                "manufacturer": DEFAULT_MANUFACTURER,
+                "name": DEFAULT_NAME,
             }
 
     async def async_read_registers(self) -> dict[str, Any]: