refactor: update transfer-sol tests for improved clarity and functionality

* Renamed test suite to "Anchor: Transfer SOL" for better context.
* Simplified recipient and payer account generation in tests.
* Replaced balance checks with assertions for clarity.
* Removed unused getBalances function to streamline the test code.

Author: sol-warrior

basics/transfer-sol/anchor/tests/test.ts

@@ -8,86 +8,61 @@ import {
 	sendAndConfirmTransaction,
 } from "@solana/web3.js";
 import { BN } from "bn.js";
-import type { TransferSol } from "../target/types/transfer_sol";
+import { assert } from "chai";
+import type { TransferSol } from "../target/types/transfer_sol.ts";
 
-describe.skip("transfer-sol", () => {
+describe("Anchor: Transfer SOL", () => {
 	const provider = anchor.AnchorProvider.env();
 	anchor.setProvider(provider);
 	const payer = provider.wallet as anchor.Wallet;
 	const program = anchor.workspace.TransferSol as anchor.Program<TransferSol>;
 
-	// 1 SOL
-	const transferAmount = 1 * LAMPORTS_PER_SOL;
-
-	// Generate a new keypair for the recipient
-	const recipient = new Keypair();
-
-	// Generate a new keypair to create an account owned by our program
-	const programOwnedAccount = new Keypair();
-
 	it("Transfer SOL with CPI", async () => {
-		await getBalances(payer.publicKey, recipient.publicKey, "Beginning");
+		const recipient = Keypair.generate();
 
 		await program.methods
-			.transferSolWithCpi(new BN(transferAmount))
+			.transferSolWithCpi(new BN(LAMPORTS_PER_SOL))
 			.accounts({
 				payer: payer.publicKey,
 				recipient: recipient.publicKey,
 			})
 			.rpc();
 
-		await getBalances(payer.publicKey, recipient.publicKey, "Resulting");
+		const recipientBalance = await provider.connection.getBalance(
+			recipient.publicKey,
+		);
+		assert.equal(recipientBalance, LAMPORTS_PER_SOL);
 	});
 
-	it("Create and fund account owned by our program", async () => {
-		const instruction = SystemProgram.createAccount({
+	it("Transfer SOL with Program", async () => {
+		const payerAccount = Keypair.generate();
+		const ix = SystemProgram.createAccount({
 			fromPubkey: payer.publicKey,
-			newAccountPubkey: programOwnedAccount.publicKey,
+			newAccountPubkey: payerAccount.publicKey,
 			space: 0,
-			lamports: 1 * LAMPORTS_PER_SOL, // 1 SOL
+			lamports: LAMPORTS_PER_SOL, // 1 SOL
 			programId: program.programId, // Program Owner, our program's address
 		});
 
-		const transaction = new Transaction().add(instruction);
+		const transaction = new Transaction().add(ix);
 
 		await sendAndConfirmTransaction(provider.connection, transaction, [
 			payer.payer,
-			programOwnedAccount,
+			payerAccount,
 		]);
-	});
-
-	it("Transfer SOL with Program", async () => {
-		await getBalances(
-			programOwnedAccount.publicKey,
-			payer.publicKey,
-			"Beginning",
-		);
 
+		const recipientAccount = Keypair.generate();
 		await program.methods
-			.transferSolWithProgram(new BN(transferAmount))
+			.transferSolWithProgram(new BN(LAMPORTS_PER_SOL))
 			.accounts({
-				payer: programOwnedAccount.publicKey,
-				recipient: payer.publicKey,
+				payer: payerAccount.publicKey,
+				recipient: recipientAccount.publicKey,
 			})
 			.rpc();
 
-		await getBalances(
-			programOwnedAccount.publicKey,
-			payer.publicKey,
-			"Resulting",
+		const recipientBalance = await provider.connection.getBalance(
+			recipientAccount.publicKey,
 		);
+		assert.equal(recipientBalance, LAMPORTS_PER_SOL);
 	});
-
-	async function getBalances(
-		payerPubkey: PublicKey,
-		recipientPubkey: PublicKey,
-		timeframe: string,
-	) {
-		const payerBalance = await provider.connection.getBalance(payerPubkey);
-		const recipientBalance =
-			await provider.connection.getBalance(recipientPubkey);
-		console.log(`${timeframe} balances:`);
-		console.log(`   Payer: ${payerBalance / LAMPORTS_PER_SOL}`);
-		console.log(`   Recipient: ${recipientBalance / LAMPORTS_PER_SOL}`);
-	}
 });