Merge pull request #220 from solana-foundation/fix/init-script-rename-dedup

fix: remove buggy deduplication in init-script-rename

Author: GuiBibeau

.changeset/fix-init-script-rename.md

@@ -0,0 +1,5 @@
+---
+"create-solana-dapp": patch
+---
+
+Fix init script rename failing with mismatched array lengths. The deduplication logic was breaking the 1:1 correspondence between from and to arrays.

src/utils/init-script-rename.ts

@@ -43,20 +43,16 @@ export async function initScriptRename(args: GetArgsResult, rename?: InitScriptR
     const fromNames = namesValues(from)
     const toNames = namesValues(to)
 
-    // Deduplicate the arrays to prevent multiple replacements of the same pattern
-    const uniqueFromNames = [...new Set(fromNames)]
-    const uniqueToNames = [...new Set(toNames)]
-
     for (const path of rename[from].paths) {
       const targetPath = join(args.targetDirectory, path)
       if (!(await ensureTargetPath(targetPath))) {
         log.error(`${tag}: target does not exist ${targetPath}`)
         continue
       }
       if (args.verbose) {
-        log.warn(`${tag}: ${targetPath} -> ${uniqueFromNames.join('|')} -> ${uniqueToNames.join('|')}`)
+        log.warn(`${tag}: ${targetPath} -> ${fromNames.join('|')} -> ${toNames.join('|')}`)
       }
-      await searchAndReplace(targetPath, uniqueFromNames, uniqueToNames, args.dryRun, args.verbose)
+      await searchAndReplace(targetPath, fromNames, toNames, args.dryRun, args.verbose)
     }
   }