Clippy

Author: mvines

token-lending/program/src/dex_market.rs

@@ -93,7 +93,7 @@ impl<'a> TokenConverter for TradeSimulator<'a> {
         } else {
             input_token.try_div(best_order_price)
         }?;
-        Ok(output_token_price.try_mul(self.dex_market.get_lots(currency.opposite()))?)
+        output_token_price.try_mul(self.dex_market.get_lots(currency.opposite()))
     }
 
     fn convert(
@@ -165,7 +165,7 @@ impl<'a> TradeSimulator<'a> {
 
         let input_quantity: Decimal = quantity.try_div(self.dex_market.get_lots(currency))?;
         let output_quantity = self.exchange_with_order_book(input_quantity, currency)?;
-        Ok(output_quantity.try_mul(self.dex_market.get_lots(currency.opposite()))?)
+        output_quantity.try_mul(self.dex_market.get_lots(currency.opposite()))
     }
 
     /// Exchange tokens by filling orders

token-lending/program/src/state/obligation.rs

@@ -64,10 +64,9 @@ impl Obligation {
 
     /// Maximum amount of loan that can be repaid by liquidators
     pub fn max_liquidation_amount(&self) -> Result<u64, ProgramError> {
-        Ok(self
-            .borrowed_liquidity_wads
+        self.borrowed_liquidity_wads
             .try_mul(Rate::from_percent(LIQUIDATION_CLOSE_FACTOR))?
-            .try_floor_u64()?)
+            .try_floor_u64()
     }
 
     /// Ratio of loan balance to collateral value

token-swap/program/src/curve/base.rs

@@ -247,8 +247,7 @@ mod tests {
         let unpacked = SwapCurve::unpack_from_slice(&packed).unwrap();
         assert_eq!(swap_curve, unpacked);
 
-        let mut packed = vec![];
-        packed.push(curve_type as u8);
+        let mut packed = vec![curve_type as u8];
         packed.extend_from_slice(&[0u8; 32]); // 32 bytes reserved for curve
         let unpacked = SwapCurve::unpack_from_slice(&packed).unwrap();
         assert_eq!(swap_curve, unpacked);

token-swap/program/src/instruction.rs

@@ -620,9 +620,7 @@ mod tests {
             swap_curve,
         });
         let packed = check.pack();
-        let mut expect = vec![];
-        expect.push(0u8);
-        expect.push(nonce);
+        let mut expect = vec![0u8, nonce];
         expect.extend_from_slice(&trade_fee_numerator.to_le_bytes());
         expect.extend_from_slice(&trade_fee_denominator.to_le_bytes());
         expect.extend_from_slice(&owner_trade_fee_numerator.to_le_bytes());

token-swap/program/src/state.rs

@@ -344,9 +344,7 @@ mod tests {
         let unpacked = SwapV1::unpack(&packed).unwrap();
         assert_eq!(swap_info, unpacked);
 
-        let mut packed = vec![];
-        packed.push(1u8);
-        packed.push(TEST_NONCE);
+        let mut packed = vec![1u8, TEST_NONCE];
         packed.extend_from_slice(&TEST_TOKEN_PROGRAM_ID.to_bytes());
         packed.extend_from_slice(&TEST_TOKEN_A.to_bytes());
         packed.extend_from_slice(&TEST_TOKEN_B.to_bytes());