cargo clippy

Author: samkim-crypto

token/confidential-transfer/proof-generation/src/transfer_with_fee.rs

@@ -19,6 +19,7 @@ use {
             CiphertextCommitmentEqualityProofData, PercentageWithCapProofData,
         },
     },
+    std::char::MAX,
 };
 
 const MAX_FEE_BASIS_POINTS: u64 = 10_000;
@@ -244,7 +245,9 @@ pub fn transfer_with_fee_split_proof_data(
     const DELTA_BIT_LENGTH: usize = 48;
     const MAX_FEE_BASIS_POINTS: u64 = 10_000;
 
-    let delta_fee_complement = MAX_FEE_BASIS_POINTS - delta_fee;
+    let delta_fee_complement = MAX_FEE_BASIS_POINTS
+        .checked_sub(delta_fee)
+        .ok_or(TokenProofGenerationError::FeeCalculation)?;
 
     let max_fee_basis_points_commitment =
         Pedersen::with(MAX_FEE_BASIS_POINTS, &PedersenOpening::default());
@@ -320,6 +323,7 @@ fn calculate_fee(transfer_amount: u64, fee_rate_basis_points: u16) -> Option<(u6
     Some((fee as u64, delta_fee as u64))
 }
 
+#[allow(clippy::arithmetic_side_effects)]
 fn compute_delta_commitment_and_opening(
     (combined_commitment, combined_opening): (&PedersenCommitment, &PedersenOpening),
     (combined_fee_commitment, combined_fee_opening): (&PedersenCommitment, &PedersenOpening),