token-2022: Add unnecessary owner checks for more clarity (#3759)

Author: joncinque

token/program-2022/src/extension/confidential_transfer/processor.rs

@@ -874,6 +874,8 @@ fn process_withdraw_withheld_tokens_from_mint(
     let authority_info = next_account_info(account_info_iter)?;
     let authority_info_data_len = authority_info.data_len();
 
+    // unnecessary check, but helps for clarity
+    check_program_account(mint_account_info.owner)?;
     let mut mint_data = mint_account_info.data.borrow_mut();
     let mut mint = StateWithExtensionsMut::<Mint>::unpack(&mut mint_data)?;
 
@@ -969,6 +971,8 @@ fn process_withdraw_withheld_tokens_from_accounts(
         .len()
         .saturating_sub(num_token_accounts as usize);
 
+    // unnecessary check, but helps for clarity
+    check_program_account(mint_account_info.owner)?;
     let mut mint_data = mint_account_info.data.borrow_mut();
     let mut mint = StateWithExtensionsMut::<Mint>::unpack(&mut mint_data)?;
 

token/program-2022/src/extension/transfer_fee/processor.rs

@@ -119,6 +119,9 @@ fn process_withdraw_withheld_tokens_from_mint(
     let authority_info = next_account_info(account_info_iter)?;
     let authority_info_data_len = authority_info.data_len();
 
+    // unnecessary check, but helps for clarity
+    check_program_account(mint_account_info.owner)?;
+
     let mut mint_data = mint_account_info.data.borrow_mut();
     let mut mint = StateWithExtensionsMut::<Mint>::unpack(&mut mint_data)?;
     let extension = mint.get_extension_mut::<TransferFeeConfig>()?;
@@ -214,6 +217,9 @@ fn process_withdraw_withheld_tokens_from_accounts(
         .len()
         .saturating_sub(num_token_accounts as usize);
 
+    // unnecessary check, but helps for clarity
+    check_program_account(mint_account_info.owner)?;
+
     let mint_data = mint_account_info.data.borrow();
     let mint = StateWithExtensions::<Mint>::unpack(&mint_data)?;
     let extension = mint.get_extension::<TransferFeeConfig>()?;