Governance: Readme DAO update (#2257)

* chore: update readme

De-emphasize program upgrades and exhibit DAO instead

* chore: update readme

* chore: update accounts comments

* chore: use absolute vote weight source explicitly

Author: SebastianBor

governance/README.md

@@ -1,8 +1,9 @@
 # Governance
 
-Governance is a program the chief purpose of which is to control the upgrade of other programs through democratic means.
-It can also be used as an authority provider for mints and other forms of access control as well where we may want
-a voting population to vote on disbursement of access or funds collectively.
+Governance is a program the chief purpose of which is to create Decentralized Autonomous Organizations (DAOs).
+It can be used as an authority provider for mints, token accounts and other forms of access control where for example
+we may want a voting population to vote on disbursement of funds collectively.
+It can also control upgrades of itself and other programs through democratic means.
 
 ## Architecture
 
@@ -49,7 +50,7 @@ from the governed token account.
 
 ### How does the authority work?
 
-Governance can handle arbitrary executions of code, but it's real power lies in the power to upgrade programs.
+Governance can handle arbitrary executions of code. In the program governance case it can execute program upgrades.
 It does this through executing instructions to the bpf-upgradable-loader program.
 Bpf-upgradable-loader allows any signer who has Upgrade authority over a Buffer account and the Program account itself
 to upgrade it using its Upgrade command.
@@ -65,7 +66,7 @@ mint and transfer instructions for the governed accounts.
 
 ### Proposal accounts
 
-A Proposal is an instance of a Governance created to vote on and execute given set of changes.
+A Proposal is an instance of a Governance created to vote on and execute given set of instructions.
 It is created by someone (Proposal Owner) and tied to a given Governance account
 and has a set of executable instructions to it, a name and a description.
 It goes through various states (draft, voting, executing, ...) and users can vote on it
@@ -101,17 +102,31 @@ When a Proposal is created and signed by its Signatories voters can start voting
 equal to deposited governing tokens into the realm. A vote is tipped once it passes the defined `vote_threshold` of votes
 and enters Succeeded or Defeated state. If Succeeded then Proposal instructions can be executed after they hold_up_time passes.
 
-Users can relinquish their vote any time during Proposal lifetime, but once Proposal it decided their vote can't be changed.
+Users can relinquish their vote any time during Proposal lifetime, but once Proposal is decided their vote can't be changed.
 
 ### Community and Councils governing tokens
 
 Each Governance Realm that gets created has the option to also have a Council mint.
 A council mint is simply a separate mint from the Community mint.
 What this means is that users can submit Proposals that have a different voting population from a different mint
-that can affect the same program. A practical application of this policy may be to have a very large population control
+that can affect the same DAO. A practical application of this policy may be to have a very large population control
 major version bumps of Solana via normal SOL, for instance, but hot fixes be controlled via Council tokens,
 of which there may be only 30, and which may be themselves minted and distributed via proposals by the governing population.
 
+Another important use case is to use the Council for DAO inception. At the beginning of a DAO life
+there are lots of risks and unknowns.
+For example it's not known whether the community of token holders would engage and participate in DAO votes.
+And if it would engage then to what extent. It means it can be difficult for example to decide how many votes are
+required for a proposal to be successfully voted on.
+This is why in order to avoid traps and potentially irreversible actions the Council can be used as a safety net
+in a similar way to Multisig to moderate and supervise the voting process at the DAO inception.
+Once the newly born DAO goes through several successful proposal votes and everything is going smoothly
+the council can be removed from the DAO through a community vote.
+
+The Council can also be used for protocols and communities which haven't launched their token yet.
+In such cases the DAO can be setup with the yet to launch token and the Council which would governed
+the DAO until the token is distributed.
+
 ### Proposal Workflow
 
 ![Proposal Workflow](./resources/governance-workflow.jpg)

governance/program/src/instruction.rs

@@ -50,9 +50,8 @@ pub enum GovernanceInstruction {
     /// 5. `[]` System
     /// 6. `[]` SPL Token
     /// 7. `[]` Sysvar Rent
-
-    /// 9. `[]` Council Token Mint - optional
-    /// 10. `[writable]` Council Token Holding account - optional unless council is used. PDA seeds: ['governance',realm,council_mint]
+    /// 8. `[]` Council Token Mint - optional
+    /// 9. `[writable]` Council Token Holding account - optional unless council is used. PDA seeds: ['governance',realm,council_mint]
     ///     The account will be created with the Realm PDA as its owner
     CreateRealm {
         #[allow(dead_code)]
@@ -235,7 +234,7 @@ pub enum GovernanceInstruction {
     ///
     ///   0. `[writable]` Proposal account
     ///   1. `[writable]`  TokenOwnerRecord account of the  Proposal owner
-    ///   2 `[signer]` Governance Authority (Token Owner or Governance Delegate)
+    ///   2. `[signer]` Governance Authority (Token Owner or Governance Delegate)
     ///   3. `[]` Clock sysvar
     CancelProposal,
 
@@ -290,7 +289,6 @@ pub enum GovernanceInstruction {
     ///   2. `[writable]` TokenOwnerRecord account. PDA seeds: ['governance',realm, governing_token_mint, governing_token_owner]
     ///   3. `[writable]` Proposal VoteRecord account. PDA seeds: ['governance',proposal,governing_token_owner_record]
     ///   4. `[]` Governing Token Mint
-
     ///   5. `[signer]` Optional Governance Authority (Token Owner or Governance Delegate)
     ///       It's required only when Proposal is still being voted on
     ///   6. `[writable]` Optional Beneficiary account which would receive lamports when VoteRecord Account is disposed
@@ -389,12 +387,11 @@ pub enum GovernanceInstruction {
     /// Sets realm config
     ///   0. `[writable]` Realm account
     ///   1. `[signer]`  Realm authority    
-
-    ///   3. `[]` Council Token Mint - optional
+    ///   2. `[]` Council Token Mint - optional
     ///       Note: In the current version it's only possible to remove council mint (set it to None)
     ///       After setting council to None it won't be possible to withdraw the tokens from the Realm any longer
     ///       If that's required then it must be done before executing this instruction
-    ///   4. `[writable]` Council Token Holding account - optional unless council is used. PDA seeds: ['governance',realm,council_mint]
+    ///   3. `[writable]` Council Token Holding account - optional unless council is used. PDA seeds: ['governance',realm,council_mint]
     ///       The account will be created with the Realm PDA as its owner
     SetRealmConfig {
         #[allow(dead_code)]

governance/program/src/processor/process_create_program_governance.rs

@@ -36,20 +36,20 @@ pub fn process_create_program_governance(
     let account_info_iter = &mut accounts.iter();
 
     let realm_info = next_account_info(account_info_iter)?; // 0
-    let program_governance_info = next_account_info(account_info_iter)?; // 0
+    let program_governance_info = next_account_info(account_info_iter)?; // 1
 
-    let governed_program_info = next_account_info(account_info_iter)?; // 1
-    let governed_program_data_info = next_account_info(account_info_iter)?; // 2
-    let governed_program_upgrade_authority_info = next_account_info(account_info_iter)?; // 3
+    let governed_program_info = next_account_info(account_info_iter)?; // 2
+    let governed_program_data_info = next_account_info(account_info_iter)?; // 3
+    let governed_program_upgrade_authority_info = next_account_info(account_info_iter)?; // 4
 
-    let token_owner_record_info = next_account_info(account_info_iter)?; // 4
+    let token_owner_record_info = next_account_info(account_info_iter)?; // 5
 
-    let payer_info = next_account_info(account_info_iter)?; // 5
-    let bpf_upgrade_loader_info = next_account_info(account_info_iter)?; // 6
+    let payer_info = next_account_info(account_info_iter)?; // 6
+    let bpf_upgrade_loader_info = next_account_info(account_info_iter)?; // 7
 
-    let system_info = next_account_info(account_info_iter)?; // 7
+    let system_info = next_account_info(account_info_iter)?; // 8
 
-    let rent_sysvar_info = next_account_info(account_info_iter)?; // 8
+    let rent_sysvar_info = next_account_info(account_info_iter)?; // 9
     let rent = &Rent::from_account_info(rent_sysvar_info)?;
 
     assert_valid_create_governance_args(program_id, &config, realm_info)?;

governance/program/src/state/proposal.rs

@@ -280,7 +280,9 @@ impl Proposal {
 
                 Ok(max_vote_weight.max(total_vote_count))
             }
-            _ => Err(GovernanceError::VoteWeightSourceNotSupported.into()),
+            MintMaxVoteWeightSource::Absolute(_) => {
+                Err(GovernanceError::VoteWeightSourceNotSupported.into())
+            }
         }
     }
 

governance/program/src/state/realm.rs

@@ -211,7 +211,9 @@ pub fn assert_valid_realm_config_args(config_args: &RealmConfigArgs) -> Result<(
                 return Err(GovernanceError::InvalidMaxVoteWeightSupplyFraction.into());
             }
         }
-        _ => return Err(GovernanceError::MintMaxVoteWeightSourceNotSupported.into()),
+        MintMaxVoteWeightSource::Absolute(_) => {
+            return Err(GovernanceError::MintMaxVoteWeightSourceNotSupported.into())
+        }
     }
 
     Ok(())