token-2022: [OS-SPL-ADV-02] Fix instruction creator (#5900)

joncinque · web-flow · commit d3de20251f28 · 2023-11-29T12:55:46.000+01:00
* token-2022: [OS-SPL-ADV-02] Fix instruction creator

* Also make the multisig signers readonly
diff --git a/token/program-2022/src/extension/confidential_transfer_fee/instruction.rs b/token/program-2022/src/extension/confidential_transfer_fee/instruction.rs
@@ -319,7 +319,7 @@ pub fn inner_withdraw_withheld_tokens_from_mint(
     ));
 
     for multisig_signer in multisig_signers.iter() {
-        accounts.push(AccountMeta::new(**multisig_signer, false));
+        accounts.push(AccountMeta::new_readonly(**multisig_signer, true));
     }
 
     Ok(encode_instruction(
@@ -411,7 +411,7 @@ pub fn inner_withdraw_withheld_tokens_from_accounts(
     ));
 
     for multisig_signer in multisig_signers.iter() {
-        accounts.push(AccountMeta::new(**multisig_signer, false));
+        accounts.push(AccountMeta::new_readonly(**multisig_signer, true));
     }
 
     for source in sources.iter() {

Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,7 @@ pub fn inner_withdraw_withheld_tokens_from_mint(`
`319`	`319`	`));`
`320`	`320`
`321`	`321`	`for multisig_signer in multisig_signers.iter() {`
`322`		`- accounts.push(AccountMeta::new(**multisig_signer, false));`
	`322`	`+ accounts.push(AccountMeta::new_readonly(**multisig_signer, true));`
`323`	`323`	`}`
`324`	`324`
`325`	`325`	`Ok(encode_instruction(`
`@@ -411,7 +411,7 @@ pub fn inner_withdraw_withheld_tokens_from_accounts(`
`411`	`411`	`));`
`412`	`412`
`413`	`413`	`for multisig_signer in multisig_signers.iter() {`
`414`		`- accounts.push(AccountMeta::new(**multisig_signer, false));`
	`414`	`+ accounts.push(AccountMeta::new_readonly(**multisig_signer, true));`
`415`	`415`	`}`
`416`	`416`
`417`	`417`	`for source in sources.iter() {`