clippy: Deny integer arithmetic, add allows where needed (#3606)

Author: joncinque

.github/workflows/pull-request.yml

@@ -77,7 +77,7 @@ jobs:
         uses: actions-rs/cargo@v1
         with:
           command: clippy
-          args: -Zunstable-options --workspace --all-targets -- --deny=warnings
+          args: -Zunstable-options --workspace --all-targets --features test-sbf -- --deny=warnings --deny=clippy::integer_arithmetic
 
   audit:
     runs-on: ubuntu-latest

binary-option/program/src/lib.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::integer_arithmetic)]
 pub mod entrypoint;
 pub mod error;
 pub mod instruction;

binary-oracle-pair/program/tests/tests.rs

@@ -128,6 +128,7 @@ pub async fn make_decision(
     Ok(())
 }
 
+#[allow(clippy::too_many_arguments)]
 pub async fn make_withdraw(
     program_context: &mut ProgramTestContext,
     pool_account: &Pubkey,
@@ -446,6 +447,11 @@ impl TestPool {
         banks_client.process_transaction(transaction).await.unwrap();
     }
 }
+impl Default for TestPool {
+    fn default() -> Self {
+        Self::new()
+    }
+}
 
 pub async fn create_mint(
     banks_client: &mut BanksClient,
@@ -467,7 +473,7 @@ pub async fn create_mint(
             spl_token::instruction::initialize_mint(
                 &spl_token::id(),
                 &mint_account.pubkey(),
-                &owner,
+                owner,
                 None,
                 0,
             )

examples/rust/cross-program-invocation/tests/functional.rs

@@ -16,7 +16,7 @@ use {
 
 #[tokio::test]
 async fn test_cross_program_invocation() {
-    let program_id = Pubkey::from_str(&"invoker111111111111111111111111111111111111").unwrap();
+    let program_id = Pubkey::from_str("invoker111111111111111111111111111111111111").unwrap();
     let (allocated_pubkey, bump_seed) =
         Pubkey::find_program_address(&[b"You pass butter"], &program_id);
     let mut program_test = ProgramTest::new(

examples/rust/transfer-lamports/src/processor.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::integer_arithmetic)]
 //! Program instruction processor
 
 use solana_program::{

feature-proposal/cli/src/main.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::integer_arithmetic)]
 use {
     chrono::{DateTime, NaiveDateTime, SecondsFormat, Utc},
     clap::{

governance/chat/program/src/lib.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::integer_arithmetic)]
 #![deny(missing_docs)]
 //! Governance Chat program
 

governance/chat/program/tests/program_test/mod.rs

@@ -296,7 +296,7 @@ impl GovernanceChatProgramTest {
             token_owner_record_address,
             token_owner,
             governing_token_mint: governing_token_mint_keypair.pubkey(),
-            governing_token_mint_authority: governing_token_mint_authority,
+            governing_token_mint_authority,
             voter_weight_record,
         }
     }

governance/program/src/lib.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::integer_arithmetic)]
 #![deny(missing_docs)]
 //! A Governance program for the Solana blockchain.
 

governance/program/tests/process_cast_vote.rs

@@ -1506,9 +1506,12 @@ async fn test_cast_vote_with_strict_tipping_and_inflated_max_vote_weight() {
     let mut governance_test = GovernanceProgramTest::start_new().await;
 
     // Reduce max voter weight to 50% for the cast vote to be above max_voter_weight
-    let mut realm_config_args = RealmSetupArgs::default();
-    realm_config_args.community_mint_max_vote_weight_source =
-        MintMaxVoteWeightSource::SupplyFraction(MintMaxVoteWeightSource::SUPPLY_FRACTION_BASE / 2);
+    let realm_config_args = RealmSetupArgs {
+        community_mint_max_vote_weight_source: MintMaxVoteWeightSource::SupplyFraction(
+            MintMaxVoteWeightSource::SUPPLY_FRACTION_BASE / 2,
+        ),
+        ..Default::default()
+    };
 
     let realm_cookie = governance_test
         .with_realm_using_args(&realm_config_args)