From ffa26ea8cf0385d2f35a32f0594ff43ebed9ecf9 Mon Sep 17 00:00:00 2001 From: Ryo Onodera Date: Wed, 17 May 2023 21:00:05 +0900 Subject: [PATCH] Temporarily use stable clippy for redundant_clone --- ci/test-checks.sh | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/ci/test-checks.sh b/ci/test-checks.sh index a2ea2a6c24b9ac..52661cf212d146 100755 --- a/ci/test-checks.sh +++ b/ci/test-checks.sh @@ -85,6 +85,18 @@ nightly_clippy_allows=(--allow=clippy::redundant_clone) --deny=clippy::used_underscore_binding \ "${nightly_clippy_allows[@]}" +# temporarily run stable clippy as well to scan the codebase for +# `redundant_clone`s, which is disabled as nightly clippy is buggy: +# https://github.com/rust-lang/rust-clippy/issues/10577 +# +# can't use --all-targets: +# error[E0554]: `#![feature]` may not be used on the stable release channel +_ scripts/cargo-for-all-lock-files.sh -- clippy --workspace --tests --bins --examples --features dummy-for-ci-check -- \ + --deny=warnings \ + --deny=clippy::default_trait_access \ + --deny=clippy::integer_arithmetic \ + --deny=clippy::used_underscore_binding + if [[ -n $CI ]]; then # exclude from printing "Checking xxx ..." _ scripts/cargo-for-all-lock-files.sh -- "+${rust_nightly}" sort --workspace --check > /dev/null