[js-client] Add tsc --noEmit to the js client test script and fix type error (#143)

add `tsc --noEmit` to test script

Author: samkim-crypto

clients/js/package.json

@@ -21,7 +21,7 @@
     "scripts": {
         "build": "rimraf dist && tsup && tsc -p ./tsconfig.declarations.json",
         "build:docs": "typedoc",
-        "test": "ava",
+        "test": "tsc --noEmit && ava",
         "lint": "eslint src",
         "lint:fix": "eslint --fix src",
         "format": "prettier --check src test",

clients/js/test/_setup.ts

@@ -12,6 +12,7 @@ import {
   airdropFactory,
   appendTransactionMessageInstructions,
   assertIsSendableTransaction,
+  assertIsTransactionWithBlockhashLifetime,
   createSolanaRpc,
   createSolanaRpcSubscriptions,
   createTransactionMessage,
@@ -68,6 +69,7 @@ export const signAndSendTransaction = async (
   const signedTransaction = await signTransactionMessageWithSigners(transactionMessage);
   const signature = getSignatureFromTransaction(signedTransaction);
   assertIsSendableTransaction(signedTransaction);
+  assertIsTransactionWithBlockhashLifetime(signedTransaction);
   await sendAndConfirmTransactionFactory(client)(signedTransaction, {
     commitment,
   });

clients/js/test/basic.test.ts

@@ -5,8 +5,6 @@ import {
   createRecord,
   createWriteInstruction,
   reallocateRecord,
-  createSetAuthorityInstruction,
-  createCloseRecordInstruction,
   RECORD_META_DATA_SIZE,
 } from '../src';
 import {
@@ -20,7 +18,6 @@ test('basic instructions flow', async t => {
   const payer = await generateKeyPairSignerWithSol(client);
 
   const recordAuthority = await generateKeyPairSigner();
-  const newRecordAuthority = await generateKeyPairSigner();
 
   const initialRecordSize = 0n;
   const newRecordSize = 5n;