rust-legacy: Lighten dependencies (#662)

#### Problem

The rust token-client has dependencies on solana-program-test and
solana-sdk, which are very heavy to build, but none of them are strictly
required.

#### Summary of changes

Remove all usage of solana-sdk, and gate solana-program-test usage
behind the `dev-context-only-utils` feature, since those are only ever
used in tests.

On my machine, build times go down from ~1m to 18s!

Author: joncinque

Cargo.lock

@@ -12,6 +12,11 @@ edition = { workspace = true }
 
 [features]
 default = ["display"]
+dev-context-only-utils = [
+    "dep:solana-banks-client",
+    "dep:solana-banks-interface",
+    "dep:solana-program-test",
+]
 display = ["dep:solana-cli-output"]
 
 [dependencies]
@@ -20,13 +25,25 @@ bincode = "1.3.2"
 bytemuck = "1.23.1"
 futures = "0.3.31"
 futures-util = "0.3"
-solana-banks-interface = "2.3.4"
+solana-account = "2.2.1"
+solana-banks-client = { version = "2.3.4", optional = true }
+solana-banks-interface = { version = "2.3.4", optional = true }
+solana-compute-budget-interface = "2.2.1"
 solana-cli-output = { version = "2.2.0", optional = true }
-solana-program-test = "2.3.4"
+solana-hash = "2.2.1"
+solana-instruction = "2.2.1"
+solana-message = "2.2.1"
+solana-packet = "2.2.1"
+solana-program-error = "2.2.1"
+solana-program-pack = "2.2.1"
+solana-program-test = { version = "2.3.4", optional = true }
+solana-pubkey = "2.2.1"
 solana-rpc-client = "2.3.4"
 solana-rpc-client-api = "2.3.4"
-solana-sdk = "2.2.1"
+solana-signature = "2.2.1"
+solana-signer = "2.2.1"
 solana-system-interface = "1"
+solana-transaction = "2.2.1"
 spl-associated-token-account-client = { version = "2.0.0" }
 spl-elgamal-registry = { version = "0.3.0",features = ["no-entrypoint"], path = "../../confidential-transfer/elgamal-registry"}
 spl-memo = { version = "6.0", features = ["no-entrypoint"] }
@@ -38,6 +55,7 @@ spl-token-2022 = { version = "9.0.0", features = ["no-entrypoint"], path = "../.
 spl-token-group-interface = { version = "0.6.0" }
 spl-token-metadata-interface = { version = "0.7.0" }
 spl-transfer-hook-interface = { version = "0.10.0" }
+tokio = "1"
 thiserror = "2.0"
 
 [dev-dependencies]
@@ -46,8 +64,11 @@ borsh = "1.5.7"
 bytemuck = "1.23.1"
 futures-util = "0.3"
 solana-program = "2.3.0"
+solana-program-test = "2.3.4"
+solana-sdk = "2.2.1"
 spl-associated-token-account = { version = "7.0.0" }
 spl-pod = { version = "0.5.1" }
 spl-instruction-padding = { version = "0.3.0", features = ["no-entrypoint"] }
 spl-tlv-account-resolution = { version = "0.10.0" }
+spl-token-client = { path = ".", features = ["dev-context-only-utils"] }
 test-case = "3.3"

clients/rust-legacy/Cargo.toml

@@ -1,16 +1,21 @@
 use {
     async_trait::async_trait,
-    solana_banks_interface::BanksTransactionResultWithSimulation,
-    solana_program_test::{tokio::sync::Mutex, BanksClient, ProgramTestContext},
+    solana_account::Account,
+    solana_hash::Hash,
+    solana_pubkey::Pubkey,
     solana_rpc_client::nonblocking::rpc_client::RpcClient,
     solana_rpc_client_api::response::RpcSimulateTransactionResult,
-    solana_sdk::{
-        account::Account, hash::Hash, pubkey::Pubkey, signature::Signature,
-        transaction::Transaction,
-    },
+    solana_signature::Signature,
+    solana_transaction::Transaction,
     std::{fmt, future::Future, pin::Pin, sync::Arc},
 };
 
+#[cfg(feature = "dev-context-only-utils")]
+use {
+    solana_banks_client::BanksClient, solana_banks_interface::BanksTransactionResultWithSimulation,
+    solana_program_test::ProgramTestContext, tokio::sync::Mutex,
+};
+
 type BoxFuture<'a, T> = Pin<Box<dyn Future<Output = T> + Send + 'a>>;
 
 /// Basic trait for sending transactions to validator.
@@ -30,6 +35,7 @@ pub trait SimulationResult {
 
 /// Extends basic `SendTransaction` trait with function `send` where client is
 /// `&mut BanksClient`. Required for `ProgramBanksClient`.
+#[cfg(feature = "dev-context-only-utils")]
 pub trait SendTransactionBanksClient: SendTransaction {
     fn send<'a>(
         &self,
@@ -40,6 +46,7 @@ pub trait SendTransactionBanksClient: SendTransaction {
 
 /// Extends basic `SimulateTransaction` trait with function `simulation` where
 /// client is `&mut BanksClient`. Required for `ProgramBanksClient`.
+#[cfg(feature = "dev-context-only-utils")]
 pub trait SimulateTransactionBanksClient: SimulateTransaction {
     fn simulate<'a>(
         &self,
@@ -50,12 +57,15 @@ pub trait SimulateTransactionBanksClient: SimulateTransaction {
 
 /// Send transaction to validator using `BanksClient::process_transaction`.
 #[derive(Debug, Clone, Copy, Default)]
+#[cfg(feature = "dev-context-only-utils")]
 pub struct ProgramBanksClientProcessTransaction;
 
+#[cfg(feature = "dev-context-only-utils")]
 impl SendTransaction for ProgramBanksClientProcessTransaction {
     type Output = ();
 }
 
+#[cfg(feature = "dev-context-only-utils")]
 impl SendTransactionBanksClient for ProgramBanksClientProcessTransaction {
     fn send<'a>(
         &self,
@@ -71,6 +81,7 @@ impl SendTransactionBanksClient for ProgramBanksClientProcessTransaction {
     }
 }
 
+#[cfg(feature = "dev-context-only-utils")]
 impl SimulationResult for BanksTransactionResultWithSimulation {
     fn get_compute_units_consumed(&self) -> ProgramClientResult<u64> {
         self.simulation_details
@@ -80,10 +91,12 @@ impl SimulationResult for BanksTransactionResultWithSimulation {
     }
 }
 
+#[cfg(feature = "dev-context-only-utils")]
 impl SimulateTransaction for ProgramBanksClientProcessTransaction {
     type SimulationOutput = BanksTransactionResultWithSimulation;
 }
 
+#[cfg(feature = "dev-context-only-utils")]
 impl SimulateTransactionBanksClient for ProgramBanksClientProcessTransaction {
     fn simulate<'a>(
         &self,
@@ -213,23 +226,27 @@ where
     ) -> ProgramClientResult<ST::SimulationOutput>;
 }
 
+#[cfg(feature = "dev-context-only-utils")]
 enum ProgramBanksClientContext {
     Client(Arc<Mutex<BanksClient>>),
     Context(Arc<Mutex<ProgramTestContext>>),
 }
 
 /// Program client for `BanksClient` from crate `solana-program-test`.
+#[cfg(feature = "dev-context-only-utils")]
 pub struct ProgramBanksClient<ST> {
     context: ProgramBanksClientContext,
     send: ST,
 }
 
+#[cfg(feature = "dev-context-only-utils")]
 impl<ST> fmt::Debug for ProgramBanksClient<ST> {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         f.debug_struct("ProgramBanksClient").finish()
     }
 }
 
+#[cfg(feature = "dev-context-only-utils")]
 impl<ST> ProgramBanksClient<ST> {
     fn new(context: ProgramBanksClientContext, send: ST) -> Self {
         Self { context, send }
@@ -260,6 +277,7 @@ impl<ST> ProgramBanksClient<ST> {
     }
 }
 
+#[cfg(feature = "dev-context-only-utils")]
 #[async_trait]
 impl<ST> ProgramClient<ST> for ProgramBanksClient<ST>
 where

clients/rust-legacy/src/client.rs

@@ -5,22 +5,19 @@ use {
     bytemuck::{bytes_of, Pod},
     futures::future::join_all,
     futures_util::TryFutureExt,
-    solana_program_test::tokio::time,
-    solana_sdk::{
-        account::Account as BaseAccount,
-        compute_budget::ComputeBudgetInstruction,
-        hash::Hash,
-        instruction::{AccountMeta, Instruction},
-        message::Message,
-        packet::PACKET_DATA_SIZE,
-        program_error::ProgramError,
-        program_pack::Pack,
-        pubkey::Pubkey,
-        signature::Signature,
-        signer::{signers::Signers, Signer, SignerError},
-        transaction::Transaction,
-    },
+    solana_account::Account as BaseAccount,
+    solana_compute_budget_interface::ComputeBudgetInstruction,
+    solana_hash::Hash,
+    solana_instruction::{AccountMeta, Instruction},
+    solana_message::Message,
+    solana_packet::PACKET_DATA_SIZE,
+    solana_program_error::ProgramError,
+    solana_program_pack::Pack,
+    solana_pubkey::Pubkey,
+    solana_signature::Signature,
+    solana_signer::{signers::Signers, Signer, SignerError},
     solana_system_interface::instruction as system_instruction,
+    solana_transaction::Transaction,
     spl_associated_token_account_client::{
         address::get_associated_token_address_with_program_id,
         instruction::{
@@ -87,6 +84,7 @@ use {
         time::{Duration, Instant},
     },
     thiserror::Error,
+    tokio::time,
 };
 
 #[derive(Error, Debug)]