Skip to content

Commit 750c3ad

Browse files
authored
Fix ESP32 board variant build parameter, and fix M5Core2 make (lvgl#91)
1 parent 4fae3e1 commit 750c3ad

File tree

6 files changed

+8
-6
lines changed

6 files changed

+8
-6
lines changed

README-LVGL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ Here is the command to build ESP32 + LVGL which is compatible with ILI9341 drive
109109

110110
```
111111
make -C mpy-cross
112-
make -C ports/esp32 LV_CFLAGS="-DLV_COLOR_DEPTH=16" BOARD=ESP32_GENERIC VARIANT=SPIRAM deploy
112+
make -C ports/esp32 LV_CFLAGS="-DLV_COLOR_DEPTH=16" BOARD=ESP32_GENERIC BOARD_VARIANT=SPIRAM deploy
113113
```
114114

115115
Explanation about the parameters:

ports/esp32/boards/M5STACK_CORE2/board.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"features": [
77
"BLE",
88
"WiFi",
9+
"Dual-core",
910
"External Flash",
1011
"External RAM",
1112
"SDCard",

ports/esp32/boards/M5STACK_CORE2/mpconfigboard.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
set(SDKCONFIG_DEFAULTS
22
boards/sdkconfig.base
3+
${SDKCONFIG_IDF_VERSION_SPECIFIC}
34
boards/sdkconfig.ble
45
boards/sdkconfig.240mhz
56
boards/sdkconfig.spiram

scripts/build-esp32.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ cd $MICROPYTHON
1414
make -C mpy-cross
1515

1616
cd $MICROPYTHON/ports/esp32
17-
make BOARD=$BOARD VARIANT=$VARIANT
17+
make BOARD=$BOARD BOARD_VARIANT=$BOARD_VARIANT

scripts/deploy-esp32.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ if [ -z "$BOARD" ]; then
1111
fi
1212

1313
cd $MICROPYTHON/ports/esp32
14-
make deploy BOARD=$BOARD VARIANT=$VARIANT
14+
make deploy BOARD=$BOARD BOARD_VARIANT=$VARIANT

scripts/menu-esp32.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ if [[ $choice -lt 1 || $choice -gt ${#configs[@]} ]]; then
3131
exit 1
3232
fi
3333

34-
# Set BOARD and VARIANT based on user choice
34+
# Set BOARD and BOARD_VARIANT based on user choice
3535
selected_config=(${configs[$((choice-1))]})
3636
BOARD=${selected_config[0]}
37-
VARIANT=${selected_config[1]:-""}
37+
BOARD_VARIANT=${selected_config[1]:-""}
3838

39-
echo "Selected configuration: BOARD=$BOARD, VARIANT=$VARIANT"
39+
echo "Selected configuration: BOARD=$BOARD, BOARD_VARIANT=$BOARD_VARIANT"

0 commit comments

Comments
 (0)