ensure floats

Author: mkalkbrenner

src/Core/Query/Helper.php

@@ -590,7 +590,7 @@ public function knn(string $field, array $vector, ?int $topK = null, ?string $pr
         return $this->qparser(
             'knn',
             $params,
-        ).'['.implode(', ', $vector).']';
+        ).$this->getFloatList($vector);
     }
 
     /**
@@ -650,7 +650,7 @@ public function vectorSimilarity(string $field, array $vector, float $minReturn,
         return $this->qparser(
             'vectorSimilarity',
             $params,
-        ).'['.implode(', ', $vector).']';
+        ).$this->getFloatList($vector);
     }
 
     /**
@@ -680,4 +680,21 @@ protected function getCommonVectorParams (string $field, ?string $preFilter = nu
 
         return $params;
     }
+
+    /**
+     * Get a float list as a string.
+     *
+     * @param float[] $values
+     *
+     * @return string
+     */
+    protected function getFloatList(array $values): string
+    {
+        return '['.implode(', ', array_map(function ($value) {
+            if ($value == (int) $value) {
+                return number_format($value, 1, '.', '');
+            }
+            return (string) $value;
+        }, $values)).']';
+    }
 }

tests/Core/Query/HelperTest.php

@@ -779,12 +779,12 @@ public function testKnn(): void
     public function testKnnTextToVector(): void
     {
         $this->assertSame(
-            '{!knn_text_to_vector f=vector model=a-model, topK=10}hello world query',
+            '{!knn_text_to_vector f=vector model=a-model topK=10}hello world query',
             $this->helper->knnTextToVector('a-model', 'vector', 'hello world query', 10)
         );
 
         $this->assertSame(
-            '{!knn_text_to_vector f=vector preFilter=category:AAA preFilter=inStock:true model=a-model, topK=10}hello world query',
+            '{!knn_text_to_vector f=vector preFilter=category:AAA preFilter=inStock:true model=a-model topK=10}hello world query',
             $this->helper->knnTextToVector('a-model', 'vector', 'hello world query', 10, 'category:AAA', 'inStock:true')
         );
     }