Skip to content

Commit e92c8dd

Browse files
Merge pull request openshift#2747 from rexagod/misspell
OCPBUGS-65600: fetch misspell binary upon invocation and fix CHANGELOG typo
2 parents 654d67f + ec7db5d commit e92c8dd

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
- `KubePdbNotEnoughHealthyPods`
88
- `KubeNodePressure`
99
- `KubeNodeEviction`
10-
- [#2677](https://github.com/openshift/cluster-monitoring-operator/pull/2677) Fix KSM deny-list typo that put `^kube_.+_annotations$^kube_customresource_.+_annotations_info$,` in the deny-list instead of seperate entries, like so, `^kube_.+_annotations$,^kube_customresource_.+_annotations_info$,`, due to the omission of a comma.
10+
- [#2677](https://github.com/openshift/cluster-monitoring-operator/pull/2677) Fix KSM deny-list typo that put `^kube_.+_annotations$^kube_customresource_.+_annotations_info$,` in the deny-list instead of separate entries, like so, `^kube_.+_annotations$,^kube_customresource_.+_annotations_info$,`, due to the omission of a comma.
1111

1212
## 4.18
1313

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ GOLANGCI_LINT_VERSION=v1.64.8
4242
PROMTOOL_BIN=$(BIN_DIR)/promtool
4343
DOCGEN_BIN=$(BIN_DIR)/docgen
4444
MISSPELL_BIN=$(BIN_DIR)/misspell
45-
TOOLING=$(EMBEDMD_BIN) $(JB_BIN) $(GOJSONTOYAML_BIN) $(JSONNET_BIN) $(JSONNETFMT_BIN) $(PROMTOOL_BIN) $(DOCGEN_BIN) $(GOLANGCI_LINT_BIN)
45+
TOOLING=$(EMBEDMD_BIN) $(JB_BIN) $(GOJSONTOYAML_BIN) $(JSONNET_BIN) $(JSONNETFMT_BIN) $(PROMTOOL_BIN) $(DOCGEN_BIN) $(GOLANGCI_LINT_BIN) $(MISSPELL_BIN)
4646

4747
MANIFESTS_DIR ?= $(shell pwd)/manifests
4848
JSON_MANIFESTS_DIR ?= $(shell pwd)/tmp/json-manifests/manifests
@@ -226,11 +226,11 @@ golangci-lint-fix: $(GOLANGCI_LINT_BIN)
226226
$(GOLANGCI_LINT_BIN) run --verbose --print-resources-usage --fix
227227

228228
.PHONY:
229-
misspell:
229+
misspell: $(MISSPELL_BIN)
230230
$(MISSPELL_BIN) -error $(MARKDOWN_DOCS)
231231

232232
.PHONY:
233-
misspell-fix:
233+
misspell-fix: $(MISSPELL_BIN)
234234
$(MISSPELL_BIN) -w $(MARKDOWN_DOCS)
235235

236236
.PHONY: jsonnet-fmt

0 commit comments

Comments
 (0)