Skip to content

Commit 16d8d71

Browse files
Merge pull request #486 from pinpong/master
fixed getVolume
2 parents 4bb85a9 + 48027c2 commit 16d8d71

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

flutter_vlc_player/android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ android {
4141

4242
dependencies {
4343
implementation fileTree(include: ['*.jar'], dir: 'libs')
44-
implementation 'org.videolan.android:libvlc-all:3.6.0-eap9'
44+
implementation 'org.videolan.android:libvlc-all:3.6.0-eap12'
4545
implementation 'androidx.appcompat:appcompat:1.2.0'
4646
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
4747
implementation 'androidx.annotation:annotation:1.2.0'

flutter_vlc_player/ios/flutter_vlc_player.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Pod::Spec.new do |s|
1616
s.source_files = 'Classes/**/*'
1717
s.dependency 'Flutter'
1818
s.platform = :ios, '11.0'
19-
s.dependency 'MobileVLCKit', '~> 3.6.0b9'
19+
s.dependency 'MobileVLCKit', '~> 3.6.0b12'
2020
s.static_framework = true
2121

2222
# Flutter.framework does not contain a i386 slice.

flutter_vlc_player/lib/src/vlc_player_controller.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -568,11 +568,11 @@ class VlcPlayerController extends ValueNotifier<VlcPlayerValue> {
568568
}
569569

570570
/// Returns current vlc volume level.
571-
Future<int> getVolume() async {
571+
Future<int?> getVolume() async {
572572
_throwIfNotInitialized('getVolume');
573-
final volume =
574-
await (vlcPlayerPlatform.getVolume(_viewId) as FutureOr<int>);
575-
value = value.copyWith(volume: volume.clamp(0, _maxVolume));
573+
final volume = await vlcPlayerPlatform.getVolume(_viewId);
574+
value = value.copyWith(
575+
volume: volume != null ? volume.clamp(0, _maxVolume) : null);
576576

577577
return volume;
578578
}

0 commit comments

Comments
 (0)