update code for new lint

Author: solid-oleksandrhordiienko

flutter_vlc_player/example/ios/Runner.xcodeproj/project.pbxproj

@@ -3,7 +3,7 @@
 	archiveVersion = 1;
 	classes = {
 	};
-	objectVersion = 51;
+	objectVersion = 54;
 	objects = {
 
 /* Begin PBXBuildFile section */
@@ -211,6 +211,7 @@
 /* Begin PBXShellScriptBuildPhase section */
 		3B06AD1E1E4923F5004D2608 /* Thin Binary */ = {
 			isa = PBXShellScriptBuildPhase;
+			alwaysOutOfDate = 1;
 			buildActionMask = 2147483647;
 			files = (
 			);
@@ -264,6 +265,7 @@
 		};
 		9740EEB61CF901F6004384FC /* Run Script */ = {
 			isa = PBXShellScriptBuildPhase;
+			alwaysOutOfDate = 1;
 			buildActionMask = 2147483647;
 			files = (
 			);

flutter_vlc_player/example/ios/Runner/Info.plist

@@ -54,5 +54,7 @@
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
 	<false/>
+	<key>UIApplicationSupportsIndirectInputEvents</key>
+	<true/>
 </dict>
 </plist>

flutter_vlc_player/example/lib/controls_overlay.dart

@@ -1,11 +1,8 @@
 import 'package:flutter/material.dart';
+
 import 'package:flutter_vlc_player/flutter_vlc_player.dart';
 
 class ControlsOverlay extends StatelessWidget {
-  const ControlsOverlay({Key key, this.controller}) : super(key: key);
-
-  final VlcPlayerController controller;
-
   static const double _playButtonIconSize = 80;
   static const double _replayButtonIconSize = 100;
   static const double _seekButtonIconSize = 48;
@@ -15,11 +12,15 @@ class ControlsOverlay extends StatelessWidget {
 
   static const Color _iconColor = Colors.white;
 
+  final VlcPlayerController controller;
+
+  const ControlsOverlay({Key key, this.controller}) : super(key: key);
+
   @override
   Widget build(BuildContext context) {
     return AnimatedSwitcher(
-      duration: Duration(milliseconds: 50),
-      reverseDuration: Duration(milliseconds: 200),
+      duration: const Duration(milliseconds: 50),
+      reverseDuration: const Duration(milliseconds: 200),
       child: Builder(
         builder: (ctx) {
           if (controller.value.isEnded || controller.value.hasError) {
@@ -29,7 +30,7 @@ class ControlsOverlay extends StatelessWidget {
                   onPressed: _replay,
                   color: _iconColor,
                   iconSize: _replayButtonIconSize,
-                  icon: Icon(Icons.replay),
+                  icon: const Icon(Icons.replay),
                 ),
               ),
             );
@@ -40,7 +41,7 @@ class ControlsOverlay extends StatelessWidget {
             case PlayingState.stopped:
             case PlayingState.paused:
               return SizedBox.expand(
-                child: Container(
+                child: ColoredBox(
                   color: Colors.black45,
                   child: FittedBox(
                     child: Row(
@@ -51,19 +52,19 @@ class ControlsOverlay extends StatelessWidget {
                           onPressed: () => _seekRelative(_seekStepBackward),
                           color: _iconColor,
                           iconSize: _seekButtonIconSize,
-                          icon: Icon(Icons.replay_10),
+                          icon: const Icon(Icons.replay_10),
                         ),
                         IconButton(
                           onPressed: _play,
                           color: _iconColor,
                           iconSize: _playButtonIconSize,
-                          icon: Icon(Icons.play_arrow),
+                          icon: const Icon(Icons.play_arrow),
                         ),
                         IconButton(
                           onPressed: () => _seekRelative(_seekStepForward),
                           color: _iconColor,
                           iconSize: _seekButtonIconSize,
-                          icon: Icon(Icons.forward_10),
+                          icon: const Icon(Icons.forward_10),
                         ),
                       ],
                     ),
@@ -88,13 +89,13 @@ class ControlsOverlay extends StatelessWidget {
                     onPressed: _replay,
                     color: _iconColor,
                     iconSize: _replayButtonIconSize,
-                    icon: Icon(Icons.replay),
+                    icon: const Icon(Icons.replay),
                   ),
                 ),
               );
 
             default:
-              return SizedBox.shrink();
+              return const SizedBox.shrink();
           }
         },
       ),

flutter_vlc_player/example/lib/main.dart

@@ -1,6 +1,6 @@
 import 'package:flutter/material.dart';
-import 'multiple_tab.dart';
-import 'single_tab.dart';
+import 'package:flutter_vlc_player_example/multiple_tab.dart';
+import 'package:flutter_vlc_player_example/single_tab.dart';
 
 void main() {
   runApp(
@@ -10,29 +10,31 @@ void main() {
   );
 }
 
+// ignore: prefer-match-file-name
 class App extends StatefulWidget {
   @override
   _AppState createState() => _AppState();
 }
 
 class _AppState extends State<App> {
+  static const _length = 2;
   @override
   Widget build(BuildContext context) {
     return DefaultTabController(
-      length: 2,
+      length: _length,
       child: Scaffold(
         appBar: AppBar(
           centerTitle: true,
-          title: Text('Vlc Player Example'),
-          bottom: TabBar(
+          title: const Text('Vlc Player Example'),
+          bottom: const TabBar(
             tabs: [
               Tab(text: 'Single'),
               Tab(text: 'Multiple'),
             ],
           ),
         ),
         body: TabBarView(
-          physics: NeverScrollableScrollPhysics(),
+          physics: const NeverScrollableScrollPhysics(),
           children: [
             SingleTab(),
             MultipleTab(),

flutter_vlc_player/example/lib/multiple_tab.dart

@@ -1,14 +1,17 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_vlc_player/flutter_vlc_player.dart';
 
-import 'vlc_player_with_controls.dart';
+import 'package:flutter_vlc_player_example/vlc_player_with_controls.dart';
 
 class MultipleTab extends StatefulWidget {
   @override
   _MultipleTabState createState() => _MultipleTabState();
 }
 
 class _MultipleTabState extends State<MultipleTab> {
+  static const _heightWithControls = 400.0;
+  static const _heightWithoutControls = 300.0;
+
   List<VlcPlayerController> controllers;
   List<String> urls = [
     'https://www.tomandjerryonline.com/Videos/Ford%20Mondeo%20-%20Tom%20and%20Jerry.mov',
@@ -23,7 +26,7 @@ class _MultipleTabState extends State<MultipleTab> {
     super.initState();
     controllers = <VlcPlayerController>[];
     for (var i = 0; i < urls.length; i++) {
-      var controller = VlcPlayerController.network(
+      final controller = VlcPlayerController.network(
         urls[i],
         hwAcc: HwAcc.full,
         autoPlay: false,
@@ -42,27 +45,26 @@ class _MultipleTabState extends State<MultipleTab> {
 
   @override
   Widget build(BuildContext context) {
-    return Container(
-      child: ListView.separated(
-        itemCount: controllers.length,
-        separatorBuilder: (_, index) {
-          return Divider(height: 5, thickness: 5, color: Colors.grey);
-        },
-        itemBuilder: (_, index) {
-          return Container(
-            height: showPlayerControls ? 400 : 300,
-            child: VlcPlayerWithControls(
-              controller: controllers[index],
-              showControls: showPlayerControls,
-            ),
-          );
-        },
-      ),
+    return ListView.separated(
+      itemCount: controllers.length,
+      separatorBuilder: (_, index) {
+        return const Divider(height: 5, thickness: 5, color: Colors.grey);
+      },
+      itemBuilder: (_, index) {
+        return SizedBox(
+          height:
+              showPlayerControls ? _heightWithControls : _heightWithoutControls,
+          child: VlcPlayerWithControls(
+            controller: controllers[index],
+            showControls: showPlayerControls,
+          ),
+        );
+      },
     );
   }
 
   @override
-  void dispose() async {
+  Future<void> dispose() async {
     super.dispose();
     for (final controller in controllers) {
       await controller.stopRendererScanning();