Skip to content

Commit 330bc72

Browse files
solid-yuriiprykhodkoalr2413GuillermoDLCOmitchross
authored
Merge overlay fix and renamings into master, update CHANGELOG, increment version (#297)
* updated vlc event handling code * fix vlc error description * renamed error const strings * fixed a minor bug * Avoid FlutterVlcPlayerFactory new instances onAttachedToActivity (#214) * Avoid FlutterVlcPlayerFactory new instances onAttachedToActivity * Avoid FlutterVlcPlayerFactory instances in registerWith * fix error description docs * Added onInit & onRenderer listeners * updated docs mark onInit & onRendererHandler as deprecated. * updated documentation * fix initialization value of renderer variables * fixed vlc error on adding a local subtitle/audio * Added recording feature * fix a minor issue * updated platform recording methods * updated ios recording methods * updated pubspec * Update flutter_vlc_player/ios/Classes/VlcViewBuilder.swift Co-authored-by: Yuri Prykhodko <[email protected]> * Update flutter_vlc_player/example/lib/vlc_player_with_controls.dart Co-authored-by: Yuri Prykhodko <[email protected]> * Update flutter_vlc_player/example/lib/single_tab.dart Co-authored-by: Yuri Prykhodko <[email protected]> * Update flutter_vlc_player/example/lib/single_tab.dart Co-authored-by: Yuri Prykhodko <[email protected]> * Update flutter_vlc_player/example/lib/single_tab.dart Co-authored-by: Yuri Prykhodko <[email protected]> * Update flutter_vlc_player/example/lib/vlc_player_with_controls.dart Co-authored-by: Yuri Prykhodko <[email protected]> * fixed mentioned issues migrated from pedantic to lint package updated readme * added http options updated readme * updated readme * removed http options updated readme * added vlc http options * fixed control overlay stucking issue refactored enum to follow dart naming convention removed unused imports * Overlay fix PR #285 -- suggestions (#289) * Rename viewId/textureId -> playerId * iOS project updates * rm VlcPlayerState enum * Set version 7.0.0 * Emphasize breaking change in CHANGELOG * Use `viewId` naming instead of `playerId` (#293) * Rename viewId/textureId -> playerId * iOS project updates * rm VlcPlayerState enum * Set version 7.0.0 * Emphasize breaking change in CHANGELOG * Revert "Rename viewId/textureId -> playerId" This reverts commit 9c15d5f. * Rename textureId -> viewId * Rename playerId -> viewId (#294) * Rename viewId/textureId -> playerId * iOS project updates * rm VlcPlayerState enum * Set version 7.0.0 * Emphasize breaking change in CHANGELOG * Revert "Rename viewId/textureId -> playerId" This reverts commit 9c15d5f. * Rename textureId -> viewId * More missed renames * Update changelog * Fix platform_interface dependency declaration * Give credit to illia-romanenko and solid-yuriiprykhodko * Set platform_interface version to 2.0.0 * Add Mitch Ross to credits Co-authored-by: alr2413 <[email protected]> Co-authored-by: Guillermo Jeremy De La Cruz Onton <[email protected]> Co-authored-by: Mitch Ross <[email protected]>
1 parent 7bab0c9 commit 330bc72

File tree

26 files changed

+893
-917
lines changed

26 files changed

+893
-917
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ class _MyHomePageState extends State<MyHomePage> {
147147
148148
_videoPlayerController = VlcPlayerController.network(
149149
'https://media.w3.org/2010/05/sintel/trailer.mp4',
150-
hwAcc: HwAcc.FULL,
150+
hwAcc: HwAcc.full,
151151
autoPlay: false,
152152
options: VlcPlayerOptions(),
153153
);

flutter_vlc_player/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## 7.0.0
2+
* **Breaking Change**: Refactored enum parameters to follow dart naming convention
3+
* Fixed control overlay issue after upgrading to Flutter 2.8
4+
* Fixed Dart analysis warnings
5+
* Removed unnecessary initialization delay
6+
Credits to Alireza Setayesh (https://github.com/alr2413), Mitch Ross (https://github.com/mitchross), Illia Romanenko (https://github.com/illia-romanenko) and Yurii Prykhodko (https://github.com/solid-yuriiprykhodko).
7+
18
## 6.0.5
29
* Fix issue with options applying (Android)
310
* Update VLCKit for iOS and Android

flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/FlutterVlcPlayerBuilder.java

Lines changed: 74 additions & 74 deletions
Large diffs are not rendered by default.

flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/Messages.java

Lines changed: 221 additions & 221 deletions
Large diffs are not rendered by default.

flutter_vlc_player/example/ios/Runner.xcodeproj/project.pbxproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@
155155
97C146E61CF9000F007C117D /* Project object */ = {
156156
isa = PBXProject;
157157
attributes = {
158-
LastUpgradeCheck = 1020;
158+
LastUpgradeCheck = 1300;
159159
ORGANIZATIONNAME = "";
160160
TargetAttributes = {
161161
97C146ED1CF9000F007C117D = {

flutter_vlc_player/example/ios/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

flutter_vlc_player/example/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "1220"
3+
LastUpgradeVersion = "1300"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

flutter_vlc_player/example/lib/controls_overlay.dart

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,12 @@ class ControlsOverlay extends StatelessWidget {
7373

7474
case PlayingState.buffering:
7575
case PlayingState.playing:
76-
return GestureDetector(onTap: _pause);
76+
return GestureDetector(
77+
onTap: _pause,
78+
child: Container(
79+
color: Colors.transparent,
80+
),
81+
);
7782

7883
case PlayingState.ended:
7984
case PlayingState.error:
@@ -87,6 +92,7 @@ class ControlsOverlay extends StatelessWidget {
8792
),
8893
),
8994
);
95+
9096
default:
9197
return SizedBox.shrink();
9298
}

flutter_vlc_player/example/lib/main.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'package:flutter/cupertino.dart';
21
import 'package:flutter/material.dart';
32
import 'multiple_tab.dart';
43
import 'single_tab.dart';

flutter_vlc_player/example/lib/multiple_tab.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import 'package:flutter/cupertino.dart';
21
import 'package:flutter/material.dart';
32
import 'package:flutter_vlc_player/flutter_vlc_player.dart';
43

@@ -26,7 +25,7 @@ class _MultipleTabState extends State<MultipleTab> {
2625
for (var i = 0; i < urls.length; i++) {
2726
var controller = VlcPlayerController.network(
2827
urls[i],
29-
hwAcc: HwAcc.FULL,
28+
hwAcc: HwAcc.full,
3029
autoPlay: false,
3130
options: VlcPlayerOptions(
3231
advanced: VlcAdvancedOptions([

0 commit comments

Comments
 (0)