refactor

Author: solid-oleksandrhordiienko

.github/workflows/code_check_for_flutter_vlc_player_platform_interface.yaml

@@ -9,7 +9,6 @@ jobs:
       - uses: actions/checkout@v1
 
       - name: Setup flutter
-        if: steps.check_files.outputs.files_exists == 'true'
         uses: subosito/flutter-action@v2
         with:
           channel: 'stable'

flutter_vlc_player/example/lib/single_tab.dart

@@ -13,7 +13,7 @@ class SingleTab extends StatefulWidget {
 }
 
 class _SingleTabState extends State<SingleTab> {
-  static const _networkCaching = 2000;
+  static const _networkCachingMs = 2000;
   static const _subtitlesFontSize = 30;
   static const _height = 400.0;
 
@@ -86,7 +86,7 @@ class _SingleTabState extends State<SingleTab> {
           hwAcc: HwAcc.full,
           options: VlcPlayerOptions(
             advanced: VlcAdvancedOptions([
-              VlcAdvancedOptions.networkCaching(_networkCaching),
+              VlcAdvancedOptions.networkCaching(_networkCachingMs),
             ]),
             subtitle: VlcSubtitleOptions([
               VlcSubtitleOptions.boldStyle(true),

flutter_vlc_player/example/lib/vlc_player_with_controls.dart

@@ -31,10 +31,9 @@ class VlcPlayerWithControlsState extends State<VlcPlayerWithControls>
   static const _recordingPositionOffset = 10.0;
   static const _positionedBottomSpace = 7.0;
   static const _positionedRightSpace = 3.0;
-  static const _hundred = 100.0;
+  static const _overlayWidth = 100.0;
   static const _elevation = 4.0;
   static const _aspectRatio = 16 / 9;
-  static const _thousand = 1000;
 
   final double initSnapshotRightPosition = 10;
   final double initSnapshotBottomPosition = 10;
@@ -400,7 +399,7 @@ class VlcPlayerWithControlsState extends State<VlcPlayerWithControls>
                 Expanded(
                   child: Slider(
                     min: 0,
-                    max: _hundred,
+                    max: _overlayWidth,
                     value: volumeValue,
                     onChanged: _setSoundVolume,
                   ),
@@ -454,7 +453,7 @@ class VlcPlayerWithControlsState extends State<VlcPlayerWithControls>
       sliderValue = progress.floor().toDouble();
     });
     //convert to Milliseconds since VLC requires MS to set time
-    _controller.setTime(sliderValue.toInt() * _thousand);
+    _controller.setTime(sliderValue.toInt() * Duration.millisecondsPerSecond);
   }
 
   Future<void> _getSubtitleTracks() async {
@@ -607,7 +606,7 @@ class VlcPlayerWithControlsState extends State<VlcPlayerWithControls>
       builder: (context) => Positioned(
         right: right,
         bottom: bottom,
-        width: _hundred,
+        width: _overlayWidth,
         child: Material(
           elevation: _elevation,
           child: GestureDetector(
@@ -633,7 +632,7 @@ class VlcPlayerWithControlsState extends State<VlcPlayerWithControls>
               _overlayEntry.markNeedsBuild();
             },
             onHorizontalDragEnd: (dragEndDetails) {
-              if ((initSnapshotRightPosition - right).abs() >= _hundred) {
+              if ((initSnapshotRightPosition - right).abs() >= _overlayWidth) {
                 _overlayEntry?.remove();
                 _overlayEntry = null;
               } else {
@@ -642,7 +641,8 @@ class VlcPlayerWithControlsState extends State<VlcPlayerWithControls>
               }
             },
             onVerticalDragEnd: (dragEndDetails) {
-              if ((initSnapshotBottomPosition - bottom).abs() >= _hundred) {
+              if ((initSnapshotBottomPosition - bottom).abs() >=
+                  _overlayWidth) {
                 _overlayEntry?.remove();
                 _overlayEntry = null;
               } else {

flutter_vlc_player/lib/src/vlc_player_controller.dart

@@ -1,5 +1,3 @@
-// ignore_for_file: lines_longer_than_80_chars, comment_references
-
 import 'dart:async';
 import 'dart:io';
 
@@ -179,8 +177,7 @@ class VlcPlayerController extends ValueNotifier<VlcPlayerValue> {
       throw Exception('Already Initialized');
     }
 
-    _lifeCycleObserver = VlcAppLifeCycleObserver(this);
-    _lifeCycleObserver?.initialize();
+    _lifeCycleObserver = VlcAppLifeCycleObserver(this)..initialize();
 
     await vlcPlayerPlatform.create(
       viewId: _viewId,
@@ -369,9 +366,7 @@ class VlcPlayerController extends ValueNotifier<VlcPlayerValue> {
 
   /// Notify onInit callback & all registered listeners
   void _notifyOnInitListeners() {
-    if (_onInit != null) {
-      _onInit?.call();
-    }
+    _onInit?.call();
     for (final listener in _onInitListeners) {
       listener();
     }
@@ -384,9 +379,7 @@ class VlcPlayerController extends ValueNotifier<VlcPlayerValue> {
     String? name,
   ) {
     if (id == null || name == null) return;
-    if (_onRendererHandler != null) {
-      _onRendererHandler?.call(type, id, name);
-    }
+    _onRendererHandler?.call(type, id, name);
     for (final listener in _onRendererEventListeners) {
       listener(type, id, name);
     }
@@ -507,7 +500,7 @@ class VlcPlayerController extends ValueNotifier<VlcPlayerValue> {
   }
 
   /// Sets whether or not the video should loop after playing once.
-  Future<void> setLooping({required bool looping}) async {
+  Future<void> setLooping(bool looping) async {
     _throwIfNotInitialized('setLooping');
     value = value.copyWith(isLooping: looping);
     await vlcPlayerPlatform.setLooping(_viewId, looping);

flutter_vlc_player_platform_interface/lib/src/method_channel/method_channel_vlc_player.dart

@@ -114,7 +114,7 @@ class MethodChannelVlcPlayer extends VlcPlayerPlatform {
   Stream<VlcMediaEvent> mediaEventsFor(int viewId) {
     return _mediaEventChannelFor(viewId).receiveBroadcastStream().map(
       (dynamic event) {
-        final Map<Object?, Object?> map = event as Map<Object?, Object?>;
+        final Map<String, Object?> map = event as Map<String, Object?>;
         //
         switch (map['event']) {
           case 'opening':

flutter_vlc_player_platform_interface/lib/src/utils/helpers/subtitles/vlc_subtitle_color.dart

@@ -1,6 +1,7 @@
 class VlcSubtitleColor {
-  static const _redShiftAmount = 16;
-  static const _greenShiftAmount = 8;
+  static const _bitsInByte = 8;
+  static const _redHexOffset = 2 * _bitsInByte;
+  static const _greenHexOffset = _bitsInByte;
   static const black = VlcSubtitleColor(0);
   static const gray = VlcSubtitleColor(8421504);
   static const silver = VlcSubtitleColor(12632256);
@@ -24,5 +25,5 @@ class VlcSubtitleColor {
     int red = 0,
     int green = 0,
     int blue = 0,
-  }) : value = (red << _redShiftAmount) + (green << _greenShiftAmount) + blue;
+  }) : value = (red << _redHexOffset) + (green << _greenHexOffset) + blue;
 }