Skip to content

Commit 6e77505

Browse files
Remove dispose() call on _controller from VlcPlayer (#142)
* deleted dispose() call on _controller from VlcPlayer * Changed version and added description to CHANGELOG Co-authored-by: Solid Software <[email protected]>
1 parent 6c30942 commit 6e77505

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## 4.0.3
2-
* Update VLCKit for iOS and iOS. Cleanup example Pod file. Clean up example gradle. Credits to Mitch Ross (https://github.com/mitchross).
2+
Update VLCKit for iOS and iOS. Cleanup example Pod file. Clean up example gradle. Credits to Mitch Ross (https://github.com/mitchross).
3+
Removed dispose calls on VlcPlayerController from VlcPlayer.
34

45
## 4.0.2
56
* Update Cocoapods version for VLCkit on iOS. This fixes issues with iOS 12 and Simulators. Credits to Mitch Ross (https://github.com/mitchross).

lib/flutter_vlc_player.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -187,16 +187,9 @@ class _VlcPlayerState extends State<VlcPlayer>
187187

188188
@override
189189
void deactivate() {
190-
_controller.dispose();
191190
playerInitialized = false;
192191
super.deactivate();
193192
}
194-
195-
@override
196-
void dispose() {
197-
_controller.dispose();
198-
super.dispose();
199-
}
200193
}
201194

202195
class VlcPlayerController {

0 commit comments

Comments
 (0)