android: fix minor java warnings

Author: romaingyh

flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/Enums/DataSourceType.java

@@ -3,5 +3,5 @@
 public enum DataSourceType {
     ASSET,
     NETWORK,
-    FILE;
+    FILE
 }

flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/Enums/HwAcc.java

@@ -4,5 +4,5 @@ public enum HwAcc {
     AUTOMATIC,
     DISABLED,
     DECODING,
-    FULL;
+    FULL
 }

flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/FlutterVlcPlayerFactory.java

@@ -2,6 +2,8 @@
 
 import android.content.Context;
 
+import androidx.annotation.NonNull;
+
 import io.flutter.plugin.common.BinaryMessenger;
 import io.flutter.plugin.common.StandardMessageCodec;
 import io.flutter.plugin.platform.PlatformView;
@@ -23,7 +25,7 @@ public interface KeyForAssetAndPackageName {
     private final KeyForAssetFn keyForAsset;
     private final KeyForAssetAndPackageName keyForAssetAndPackageName;
     //
-    private FlutterVlcPlayerBuilder flutterVlcPlayerBuilder;
+    private final FlutterVlcPlayerBuilder flutterVlcPlayerBuilder;
 
     public FlutterVlcPlayerFactory(BinaryMessenger messenger, TextureRegistry textureRegistry, KeyForAssetFn keyForAsset, KeyForAssetAndPackageName keyForAssetAndPackageName) {
         super(StandardMessageCodec.INSTANCE);
@@ -35,6 +37,7 @@ public FlutterVlcPlayerFactory(BinaryMessenger messenger, TextureRegistry textur
         flutterVlcPlayerBuilder = new FlutterVlcPlayerBuilder();
     }
 
+    @NonNull
     @Override
     public PlatformView create(Context context, int viewId, Object args) {
 //        Map<String, Object> params = (Map<String, Object>) args;

flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/QueuingEventSink.java

@@ -15,7 +15,7 @@
  */
 final class QueuingEventSink implements EventChannel.EventSink {
     private EventChannel.EventSink delegate;
-    private ArrayList<Object> eventQueue = new ArrayList<>();
+    private final ArrayList<Object> eventQueue = new ArrayList<>();
     private boolean done = false;
 
     public void setDelegate(EventChannel.EventSink delegate) {

flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/VLCTextureView.java

@@ -9,6 +9,8 @@
 import android.view.View;
 import android.view.ViewGroup;
 
+import androidx.annotation.NonNull;
+
 import org.videolan.libvlc.MediaPlayer;
 import org.videolan.libvlc.interfaces.IVLCVout;
 
@@ -98,7 +100,7 @@ private void updateSurfaceTexture() {
     }
 
     @Override
-    public void onSurfaceTextureAvailable(SurfaceTexture surface, int width, int height) {
+    public void onSurfaceTextureAvailable(@NonNull SurfaceTexture surface, int width, int height) {
         if (mSurfaceTexture == null || mSurfaceTexture.isReleased()) {
             mSurfaceTexture = surface;
 
@@ -127,12 +129,12 @@ public void onSurfaceTextureAvailable(SurfaceTexture surface, int width, int hei
     }
 
     @Override
-    public void onSurfaceTextureSizeChanged(SurfaceTexture surface, int width, int height) {
+    public void onSurfaceTextureSizeChanged(@NonNull SurfaceTexture surface, int width, int height) {
         setSize(width, height);
     }
 
     @Override
-    public boolean onSurfaceTextureDestroyed(SurfaceTexture surface) {
+    public boolean onSurfaceTextureDestroyed(@NonNull SurfaceTexture surface) {
         if (mMediaPlayer != null) {
             wasPlaying = mMediaPlayer.isPlaying();
         }
@@ -150,7 +152,7 @@ public boolean onSurfaceTextureDestroyed(SurfaceTexture surface) {
     }
 
     @Override
-    public void onSurfaceTextureUpdated(SurfaceTexture surface) {
+    public void onSurfaceTextureUpdated(@NonNull SurfaceTexture surface) {
 
     }
 
@@ -176,24 +178,21 @@ public void updateLayoutSize(View view) {
     }
 
     private void setSize(int width, int height) {
-        int mVideoWidth = 0;
-        int mVideoHeight = 0;
-        mVideoWidth = width;
-        mVideoHeight = height;
-        if (mVideoWidth * mVideoHeight <= 1) return;
+        if (width * height <= 1) return;
 
         // Screen size
         int w = this.getWidth();
         int h = this.getHeight();
 
         // Size
+        // TODO: fix this always false condition, it seems to reverse the width and height
         if (w > h && w < h) {
             int i = w;
             w = h;
             h = i;
         }
 
-        float videoAR = (float) mVideoWidth / (float) mVideoHeight;
+        float videoAR = (float) width / (float) height;
         float screenAR = (float) w / (float) h;
 
         if (screenAR < videoAR) {