rename(no_empty_block): allow_comments to allow_with_comments

Author: Andrew-Bekhiet

lib/src/lints/no_empty_block/models/no_empty_block_parameters.dart

@@ -3,25 +3,25 @@ import 'package:solid_lints/src/common/parameters/excluded_identifiers_list_para
 /// A data model class that represents the "no empty block" lint input
 /// parameters.
 class NoEmptyBlockParameters {
-  static const _allowCommentsConfig = 'allow_comments';
+  static const _allowWithCommentsConfig = 'allow_with_comments';
 
   /// A list of methods that should be excluded from the lint.
   final ExcludedIdentifiersListParameter exclude;
 
   /// Whether to exclude empty blocks that contain any comments.
-  final bool allowComments;
+  final bool allowWithComments;
 
   /// Constructor for [NoEmptyBlockParameters] model
   NoEmptyBlockParameters({
     required this.exclude,
-    required this.allowComments,
+    required this.allowWithComments,
   });
 
   /// Method for creating from json data
   factory NoEmptyBlockParameters.fromJson(Map<String, dynamic> json) {
     return NoEmptyBlockParameters(
       exclude: ExcludedIdentifiersListParameter.defaultFromJson(json),
-      allowComments: json[_allowCommentsConfig] as bool? ?? false,
+      allowWithComments: json[_allowWithCommentsConfig] as bool? ?? false,
     );
   }
 }

lib/src/lints/no_empty_block/no_empty_block_rule.dart

@@ -82,7 +82,7 @@ class NoEmptyBlockRule extends SolidLintRule<NoEmptyBlockParameters> {
       if (isIgnored) return;
 
       final visitor = NoEmptyBlockVisitor(
-        allowComments: config.parameters.allowComments,
+        allowWithComments: config.parameters.allowWithComments,
       );
       node.accept(visitor);
 

lib/src/lints/no_empty_block/visitors/no_empty_block_visitor.dart

@@ -29,15 +29,15 @@ const _todoComment = 'TODO';
 /// The AST visitor that will find all empty blocks, excluding catch blocks
 /// and blocks containing [_todoComment]
 class NoEmptyBlockVisitor extends RecursiveAstVisitor<void> {
-  final bool _allowComments;
+  final bool _allowWithComments;
 
   final _emptyBlocks = <Block>[];
 
   /// Constructor for [NoEmptyBlockVisitor]
-  /// [_allowComments] indicates whether to allow empty blocks that contain
+  /// [_allowWithComments] indicates whether to allow empty blocks that contain
   /// any comments
-  NoEmptyBlockVisitor({required bool allowComments})
-      : _allowComments = allowComments;
+  NoEmptyBlockVisitor({required bool allowWithComments})
+      : _allowWithComments = allowWithComments;
 
   /// All empty blocks
   Iterable<Block> get emptyBlocks => _emptyBlocks;
@@ -48,7 +48,7 @@ class NoEmptyBlockVisitor extends RecursiveAstVisitor<void> {
 
     if (node.statements.isNotEmpty) return;
     if (node.parent is CatchClause) return;
-    if (_allowComments && _isPrecedingCommentAny(node)) return;
+    if (_allowWithComments && _isPrecedingCommentAny(node)) return;
     if (_isPrecedingCommentToDo(node)) return;
 
     _emptyBlocks.add(node);

lint_test/analysis_options.yaml

@@ -42,7 +42,7 @@ custom_lint:
         - exclude
     - newline_before_return
     - no_empty_block:
-      allow_comments: true
+      allow_with_comments: true
       exclude:
         - class_name: Exclude
           method_name: excludeMethod