Fixed function_lines_of_code_rule.dart

Author: Aygistov

lib/src/lints/function_lines_of_code/function_lines_of_code_rule.dart

@@ -50,15 +50,25 @@ class FunctionLinesOfCodeRule
   ) {
     void checkNode(AstNode node) => _checkNode(resolver, reporter, node);
 
-    context.registry.addDeclaration((declarationNode) {
-      final isIgnored = config.parameters.exclude.shouldIgnore(declarationNode);
+    void checkDeclarationNode(Declaration node) {
+      final isIgnored = config.parameters.exclude.shouldIgnore(node);
+      if (isIgnored) {
+        return;
+      }
+      checkNode(node);
+    }
 
-      if (isIgnored) return;
+    // Check for an anonymous function
+    void checkFunctionExpressionNode(FunctionExpression node) {
+      if (node.parent is FunctionDeclaration) {
+        return;
+      }
+      checkNode(node);
+    }
 
-      context.registry.addMethodDeclaration(checkNode);
-      context.registry.addFunctionDeclaration(checkNode);
-      context.registry.addFunctionExpression(checkNode);
-    });
+    context.registry.addFunctionDeclaration(checkDeclarationNode);
+    context.registry.addMethodDeclaration(checkDeclarationNode);
+    context.registry.addFunctionExpression(checkFunctionExpressionNode);
   }
 
   void _checkNode(

lint_test/function_lines_of_code_test/analysis_options.yaml

@@ -7,5 +7,8 @@ custom_lint:
     - function_lines_of_code:
       max_lines: 5
       exclude:
-         - longFunctionExcluded
-         - longMethodExcluded
+        - class_name: ClassWithLongMethods
+          method_name: longMethodExcluded
+        - method_name: longFunctionExcluded     
+        - longFunctionExcludedByDeclarationName
+        - longMethodExcludedByDeclarationName

lint_test/function_lines_of_code_test/function_lines_of_code_test.dart

@@ -256,7 +256,7 @@ class ClassWithLongMethods {
     return i;
   }
 
-  // Excluded by excludeNames
+  // Excluded by method_name
   int longMethodExcluded() {
     var i = 0;
     i++;
@@ -267,6 +267,17 @@ class ClassWithLongMethods {
     return i;
   }
 
+// Excluded by declaration_name
+  int longMethodExcludedByDeclarationName() {
+    var i = 0;
+    i++;
+    i++;
+    i++;
+    i++;
+
+    return i;
+  }
+
   int notLongMethod() {
     var i = 0;
     i++;
@@ -481,7 +492,7 @@ int longFunction() {
   return i;
 }
 
-// Excluded by excludeNames
+// Excluded by method_name
 int longFunctionExcluded() {
   var i = 0;
   i++;
@@ -491,3 +502,34 @@ int longFunctionExcluded() {
 
   return i;
 }
+
+// Excluded by declaration_name
+int longFunctionExcludedByDeclarationName() {
+  var i = 0;
+  i++;
+  i++;
+  i++;
+  i++;
+
+  return i;
+}
+
+// expect_lint: function_lines_of_code
+final longAnonymousFunction = () {
+  var i = 0;
+  i++;
+  i++;
+  i++;
+  i++;
+
+  return i;
+};
+
+final notLongAnonymousFunction = () {
+  var i = 0;
+  i++;
+  i++;
+  i++;
+
+  return i;
+};