Merge branch 'master' into Issue-190-implement-use_nearest_context-rule

Author: Yurii Prykhodko

CHANGELOG.md

@@ -1,4 +1,5 @@
 ## 0.3.0
+
 - Added `exclude` parameter for the following lints:
   - `avoid_returning_widgets`
   - `avoid_unused_parameters`
@@ -8,6 +9,11 @@
   - `number_of_parameters`
 - BREAKING CHANGE: Renamed `excludeNames` parameter to `exclude` for `function_lines_of_code` lint.
 - Fixed an issue with `prefer_early_retrun` for throw expression
+- `number_of_parameters` lint: added `copyWith` to the default exclude list.
+- Update dependencies:
+  - Update min Dart SDK constraint to 3.5.0
+  - Update `analyzer` dependency to 7.1.0
+  - Update `custom_lint_builder` dependency to 0.7.1
 - Added `use_nearest_context` rule
 
 ## 0.2.3

example/pubspec.yaml

@@ -10,7 +10,7 @@ dependencies:
     sdk: flutter
 
 dev_dependencies:
-  custom_lint: ^0.6.7
+  custom_lint: ^0.7.1
   solid_lints:
     path: ../
-  test: ^1.20.1
+  test: ^1.25.14

lib/analysis_options.yaml

@@ -85,6 +85,8 @@ custom_lint:
 
     - number_of_parameters:
       max_parameters: 7
+      exclude:
+        - method_name: copyWith 
 
     - prefer_conditional_expressions:
       ignore_nested: true

lib/src/utils/types_utils.dart

@@ -147,7 +147,7 @@ bool _isSubclassOfWidget(DartType? type) =>
     type is InterfaceType && type.allSupertypes.any(_isWidget);
 
 // ignore: deprecated_member_use
-bool _isWidgetState(DartType? type) => type?.element2?.displayName == 'State';
+bool _isWidgetState(DartType? type) => type?.element?.displayName == 'State';
 
 bool _isSubclassOfWidgetState(DartType? type) =>
     type is InterfaceType && type.allSupertypes.any(_isWidgetState);

lint_test/analysis_options.yaml

@@ -15,7 +15,7 @@ custom_lint:
       exclude:
         - class_name: Exclude
           method_name: avoidNumberOfParameters
-        - method_name: avoidNumberOfParameters          
+        - method_name: avoidNumberOfParameters
     - function_lines_of_code:
       max_lines: 50
     - avoid_non_null_assertion

lint_test/number_of_parameters_copy_with_test/analysis_options.yaml

@@ -0,0 +1 @@
+include: ../../lib/analysis_options.yaml

lint_test/number_of_parameters_copy_with_test/lib/src/number_of_parameters_copy_with_test.dart

@@ -0,0 +1,90 @@
+// ignore_for_file: prefer_match_file_name, public_member_api_docs
+// Check number of parameters fail
+///
+/// `number_of_parameters: max_parameters`
+
+class UserDto {
+  final String a;
+  final String b;
+  final String c;
+  final String d;
+  final String e;
+  final String f;
+  final String g;
+  final String h;
+
+  const UserDto({
+    required this.a,
+    required this.b,
+    required this.c,
+    required this.d,
+    required this.e,
+    required this.f,
+    required this.g,
+    required this.h,
+  });
+
+  /// Excluded by method_name
+  UserDto copyWith({
+    String? a,
+    String? b,
+    String? c,
+    String? d,
+    String? e,
+    String? f,
+    String? g,
+    String? h,
+  }) {
+    return UserDto(
+      a: a ?? this.a,
+      b: b ?? this.b,
+      c: c ?? this.c,
+      d: d ?? this.d,
+      e: e ?? this.e,
+      f: f ?? this.f,
+      g: g ?? this.g,
+      h: h ?? this.h,
+    );
+  }
+
+  /// expect_lint: number_of_parameters
+  UserDto noCopyWith({
+    String? a,
+    String? b,
+    String? c,
+    String? d,
+    String? e,
+    String? f,
+    String? g,
+    String? h,
+  }) {
+    return UserDto(
+      a: a ?? this.a,
+      b: b ?? this.b,
+      c: c ?? this.c,
+      d: d ?? this.d,
+      e: e ?? this.e,
+      f: f ?? this.f,
+      g: g ?? this.g,
+      h: h ?? this.h,
+    );
+  }
+
+  /// Allow
+  UserDto noLongCopyWith({
+    String? a,
+    String? b,
+    String? c,
+  }) {
+    return UserDto(
+      a: a ?? this.a,
+      b: b ?? this.b,
+      c: c ?? this.c,
+      d: '',
+      e: '',
+      f: '',
+      g: '',
+      h: '',
+    );
+  }
+}

lint_test/number_of_parameters_copy_with_test/pubspec.yaml

@@ -0,0 +1,15 @@
+name: solid_lints_number_of_parameters_copy_with_test
+description: A starting point for Dart libraries or applications.
+publish_to: none
+
+environment:
+  sdk: '>=3.0.0 <4.0.0'
+
+dependencies:
+  flutter:
+    sdk: flutter
+
+dev_dependencies:
+  solid_lints:
+    path: ../../
+  test: ^1.20.1

pubspec.yaml

@@ -8,19 +8,19 @@ documentation: https://solid-software.github.io/solid_lints/docs/intro
 topics: [lints, linter, lint, analysis, analyzer]
 
 environment:
-  sdk: ">=3.0.0 <4.0.0"
+  sdk: ">=3.5.0 <4.0.0"
 
 dependencies:
-  analyzer: ^6.7.0
-  collection: ^1.17.2
-  custom_lint_builder: ^0.6.7
-  glob: ^2.1.2
-  path: ^1.8.3
-  yaml: ^3.1.2
+  analyzer: ^7.1.0
+  collection: ^1.19.0
+  custom_lint_builder: ^0.7.1
+  glob: ^2.1.3
+  path: ^1.9.1
+  yaml: ^3.1.3
 
 dev_dependencies:
-  args: ^2.4.2
+  args: ^2.6.0
   # These packages are mandatory for some of tests
   flutter:
     sdk: flutter
-  test: ^1.24.6
+  test: ^1.25.14