chore: upgrade to analyzer 8 (#223)

* chore: upgrade to analyzer 8
chore: replace usage of deprecated members

* refactor: replace use of Diagnostic.data with expando

* fix: upgrade example custom_lint dependency

* docs: add changelog for 0.3.2 release

Author: andrew-bekhiet-solid

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 0.3.2
 
 - Added `named_parameters_ordering` rule.
+- Upgraded to analyzer: ^8.4.0 and custom_lint_builder: ^0.8.1
 
 ## 0.3.1
 

example/pubspec.yaml

@@ -10,7 +10,7 @@ dependencies:
     sdk: flutter
 
 dev_dependencies:
-  custom_lint: ^0.7.1
+  custom_lint: ^0.8.1
   solid_lints:
     path: ../
   test: ^1.25.14

lib/src/common/parameters/excluded_identifiers_list_parameter.dart

@@ -55,7 +55,7 @@ class ExcludedIdentifiersListParameter {
 
   /// Returns whether the target node should be ignored during analysis.
   bool shouldIgnore(Declaration node) {
-    final declarationName = node.declaredFragment?.name2;
+    final declarationName = node.declaredFragment?.name;
 
     final excludedItem = exclude.firstWhereOrNull(
       (e) {

lib/src/lints/avoid_debug_print_in_release/avoid_debug_print_in_release_rule.dart

@@ -61,7 +61,7 @@ your `debugPrint` call in a `!kReleaseMode` check.""",
   @override
   void run(
     CustomLintResolver resolver,
-    ErrorReporter reporter,
+    DiagnosticReporter reporter,
     CustomLintContext context,
   ) {
     context.registry.addFunctionExpressionInvocation(
@@ -102,7 +102,7 @@ your `debugPrint` call in a `!kReleaseMode` check.""",
   void _checkIdentifier({
     required Identifier identifier,
     required AstNode node,
-    required ErrorReporter reporter,
+    required DiagnosticReporter reporter,
   }) {
     if (!_isDebugPrintNode(identifier)) {
       return;
@@ -137,7 +137,7 @@ your `debugPrint` call in a `!kReleaseMode` check.""",
   /// Handles variable assignment and declaration
   void _handleVariableAssignmentDeclaration({
     required AstNode node,
-    required ErrorReporter reporter,
+    required DiagnosticReporter reporter,
   }) {
     final rightOperand = _getRightOperand(node.childEntities.toList());
 
@@ -159,10 +159,10 @@ your `debugPrint` call in a `!kReleaseMode` check.""",
       case PrefixedIdentifier():
         final prefix = node.prefix.name;
         name = node.name.replaceAll('$prefix.', '');
-        sourcePath = node.element?.library2?.uri.toString() ?? '';
+        sourcePath = node.element?.library?.uri.toString() ?? '';
       case SimpleIdentifier():
         name = node.name;
-        sourcePath = node.element?.library2?.uri.toString() ?? '';
+        sourcePath = node.element?.library?.uri.toString() ?? '';
 
       default:
         return false;
@@ -193,10 +193,10 @@ your `debugPrint` call in a `!kReleaseMode` check.""",
         final prefix = node.prefix.name;
 
         name = node.name.replaceAll('$prefix.', '');
-        sourcePath = node.element?.library2?.uri.toString() ?? '';
+        sourcePath = node.element?.library?.uri.toString() ?? '';
       case SimpleIdentifier():
         name = node.name;
-        sourcePath = node.element?.library2?.uri.toString() ?? '';
+        sourcePath = node.element?.library?.uri.toString() ?? '';
       default:
         return false;
     }

lib/src/lints/avoid_final_with_getter/avoid_final_with_getter_rule.dart

@@ -1,4 +1,4 @@
-import 'package:analyzer/error/error.dart' as error;
+import 'package:analyzer/diagnostic/diagnostic.dart';
 import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/source/source_range.dart';
 import 'package:custom_lint_builder/custom_lint_builder.dart';
@@ -39,6 +39,8 @@ class AvoidFinalWithGetterRule extends SolidLintRule {
   /// the error whether we use final private fields with getters.
   static const lintName = 'avoid_final_with_getter';
 
+  final _diagnosticsInfoExpando = Expando<FinalWithGetterInfo>();
+
   AvoidFinalWithGetterRule._(super.config);
 
   /// Creates a new instance of [AvoidFinalWithGetterRule]
@@ -56,23 +58,21 @@ class AvoidFinalWithGetterRule extends SolidLintRule {
   @override
   void run(
     CustomLintResolver resolver,
-    ErrorReporter reporter,
+    DiagnosticReporter reporter,
     CustomLintContext context,
   ) {
     context.registry.addCompilationUnit((node) {
       final visitor = AvoidFinalWithGetterVisitor();
       node.accept(visitor);
 
       for (final element in visitor.getters) {
-        reporter.atNode(
-          element.getter,
-          code,
-          data: element,
-        );
+        final diagnostic = reporter.atNode(element.getter, code);
+
+        _diagnosticsInfoExpando[diagnostic] = element;
       }
     });
   }
 
   @override
-  List<Fix> getFixes() => [_FinalWithGetterFix()];
+  List<Fix> getFixes() => [_FinalWithGetterFix(_diagnosticsInfoExpando)];
 }

lib/src/lints/avoid_final_with_getter/fixes/avoid_final_with_getter_fix.dart

@@ -1,21 +1,25 @@
 part of '../avoid_final_with_getter_rule.dart';
 
 class _FinalWithGetterFix extends DartFix {
+  final Expando<FinalWithGetterInfo> _diagnosticsInfoExpando;
+
+  _FinalWithGetterFix(this._diagnosticsInfoExpando);
+
   @override
   void run(
     CustomLintResolver resolver,
     ChangeReporter reporter,
     CustomLintContext context,
-    error.AnalysisError analysisError,
-    List<error.AnalysisError> others,
+    Diagnostic diagnostic,
+    List<Diagnostic> others,
   ) {
     context.registry.addMethodDeclaration((node) {
-      if (analysisError.sourceRange.intersects(node.sourceRange)) {
-        final info = analysisError.data as FinalWithGetterInfo?;
-        if (info == null) return;
+      if (!diagnostic.sourceRange.intersects(node.sourceRange)) return;
+
+      final info = _diagnosticsInfoExpando[diagnostic];
+      if (info == null) return;
 
-        _addReplacement(reporter, info);
-      }
+      _addReplacement(reporter, info);
     });
   }
 

lib/src/lints/avoid_final_with_getter/visitors/avoid_final_with_getter_visitor.dart

@@ -1,6 +1,6 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element2.dart';
+import 'package:analyzer/dart/element/element.dart';
 import 'package:solid_lints/src/lints/avoid_final_with_getter/visitors/getter_variable_visitor.dart';
 
 /// A visitor that checks for final private fields with getters.
@@ -17,7 +17,7 @@ class AvoidFinalWithGetterVisitor extends RecursiveAstVisitor<void> {
         case MethodDeclaration(
           isGetter: true,
           declaredFragment: ExecutableFragment(
-            element: ExecutableElement2(
+            element: ExecutableElement(
               isAbstract: false,
               isPublic: true,
             )

lib/src/lints/avoid_final_with_getter/visitors/getter_variable_visitor.dart

@@ -1,6 +1,6 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element2.dart';
+import 'package:analyzer/dart/element/element.dart';
 
 /// A visitor that checks the association of the getter with
 /// the final private variable
@@ -31,14 +31,13 @@ class GetterVariableVisitor extends RecursiveAstVisitor<void> {
 
 extension on MethodDeclaration {
   int? get getterReferenceId {
-    if (body is! ExpressionFunctionBody) return null;
-
-    final expression = (body as ExpressionFunctionBody).expression;
-    if (expression is SimpleIdentifier) {
-      final element = expression.element;
-      if (element is PropertyAccessorElement2) {
-        return element.variable3?.id;
-      }
+    if (body
+        case ExpressionFunctionBody(
+          expression: SimpleIdentifier(
+            element: PropertyAccessorElement(:final variable)
+          )
+        )) {
+      return variable.id;
     }
 
     return null;

lib/src/lints/avoid_global_state/avoid_global_state_rule.dart

@@ -57,7 +57,7 @@ class AvoidGlobalStateRule extends SolidLintRule {
   @override
   void run(
     CustomLintResolver resolver,
-    ErrorReporter reporter,
+    DiagnosticReporter reporter,
     CustomLintContext context,
   ) {
     context.registry.addTopLevelVariableDeclaration(
@@ -77,7 +77,7 @@ class AvoidGlobalStateRule extends SolidLintRule {
 extension on VariableDeclaration {
   bool get isMutable => !isFinal && !isConst;
 
-  bool get isPrivate => declaredElement2?.isPrivate ?? false;
+  bool get isPrivate => declaredFragment?.element.isPrivate ?? false;
 
   bool get isPublicMutable => isMutable && !isPrivate;
 }

lib/src/lints/avoid_late_keyword/avoid_late_keyword_rule.dart

@@ -71,7 +71,7 @@ class AvoidLateKeywordRule extends SolidLintRule<AvoidLateKeywordParameters> {
   @override
   void run(
     CustomLintResolver resolver,
-    ErrorReporter reporter,
+    DiagnosticReporter reporter,
     CustomLintContext context,
   ) {
     context.registry.addVariableDeclaration((node) {