Only mark props as reactive for non-sync callbacks, fixes #110.

Author: joshwilsonvu

docs/reactivity.md

@@ -816,6 +816,12 @@ function Component(props) {
   return <div use:someHook={() => props.count} />;
 }
 
+function formObjectDispatch(formObject, action) {
+  const { field } = action.payload;
+  formObject.findIndex((props) => props.field === field);
+  formObject.findIndex((props) => props.field === field);
+}
+
 ```
 <!-- AUTO-GENERATED-CONTENT:END -->
 

src/rules/reactivity.ts

@@ -315,11 +315,11 @@ export default createRule<Options, MessageIds>({
     /** Populates the function stack. */
     const onFunctionEnter = (node: ProgramOrFunctionNode) => {
       if (isFunctionNode(node)) {
-        markPropsOnCondition(node, (props) => isPropsByName(props.name));
         if (scopeStack.syncCallbacks.has(node)) {
           // Ignore sync callbacks like Array#forEach and certain Solid primitives
           return;
         }
+        markPropsOnCondition(node, (props) => isPropsByName(props.name));
       }
       scopeStack.push(new ScopeStackItem(node));
     };

test/rules/reactivity.test.ts

@@ -328,6 +328,12 @@ export const cases = run("reactivity", rule, {
     function Component(props) {
       return <div use:someHook={() => props.count} />;
     }`,
+    // f*cking insane edge case with multiple functions taking props as sync callbacks (#110)
+    `function formObjectDispatch(formObject, action) {
+      const { field } = action.payload;
+      formObject.findIndex((props) => props.field === field);
+      formObject.findIndex((props) => props.field === field);
+    }`,
   ],
   invalid: [
     // Untracked signals