Minor cleanup, text changes to #75.

Author: joshwilsonvu

README.md

@@ -128,7 +128,7 @@ const [editedValue, setEditedValue] = createSignal(props.value);
 | ✔ |  | [solid/jsx-no-script-url](docs/jsx-no-script-url.md) | Disallow javascript: URLs. |
 | ✔ | 🔧 | [solid/jsx-no-undef](docs/jsx-no-undef.md) | Disallow references to undefined variables in JSX. Handles custom directives. |
 | ✔ |  | [solid/jsx-uses-vars](docs/jsx-uses-vars.md) | Prevent variables used in JSX from being marked as unused. |
-|  |  | [solid/no-array-handlers](docs/no-array-handlers.md) | Disallow usage of unsafe event handlers. |
+|  |  | [solid/no-array-handlers](docs/no-array-handlers.md) | Disallow usage of type-unsafe event handlers. |
 | ✔ | 🔧 | [solid/no-destructure](docs/no-destructure.md) | Disallow destructuring props. In Solid, props must be used with property accesses (`props.foo`) to preserve reactivity. This rule only tracks destructuring in the parameter list. |
 | ✔ | 🔧 | [solid/no-innerhtml](docs/no-innerhtml.md) | Disallow usage of the innerHTML attribute, which can often lead to security vulnerabilities. |
 |  |  | [solid/no-proxy-apis](docs/no-proxy-apis.md) | Disallow usage of APIs that use ES6 Proxies, only to target environments that don't support them. |

docs/no-array-handlers.md

@@ -1,6 +1,6 @@
 <!-- AUTO-GENERATED-CONTENT:START (HEADER) -->
 # solid/no-array-handlers
-Disallow usage of unsafe event handlers.
+Disallow usage of type-unsafe event handlers.
 This rule is **off** by default.
 
 [View source](../src/rules/no-array-handlers.ts) · [View tests](../test/rules/no-array-handlers.test.ts)

src/rules/event-handlers.ts

@@ -164,7 +164,7 @@ const rule: TSESLint.RuleModule<
         // string name of the name node
         const { name } = node.name;
 
-        if (!/^on[a-zA-Z].*$/.test(name)) {
+        if (!/^on[a-zA-Z]/.test(name)) {
           return; // bail if Solid doesn't consider the prop name an event handler
         }
 

src/rules/no-array-handlers.ts

@@ -6,11 +6,13 @@ const rule: TSESLint.RuleModule<"noArrayHandlers", []> = {
     type: "problem",
     docs: {
       recommended: false,
-      description: "Disallow usage of unsafe event handlers.",
+      description: "Disallow usage of type-unsafe event handlers.",
       url: "https://github.com/solidjs-community/eslint-plugin-solid/blob/main/docs/no-array-handlers.md",
     },
     schema: [],
-    messages: { noArrayHandlers: "Passing an array as an event handler is potentially unsafe." },
+    messages: {
+      noArrayHandlers: "Passing an array as an event handler is potentially type-unsafe.",
+    },
   },
   create(context) {
     return {
@@ -23,44 +25,21 @@ const rule: TSESLint.RuleModule<"noArrayHandlers", []> = {
           return; // bail if this is not a DOM/SVG element or web component
         }
 
-        if (node.name.type === "JSXNamespacedName") {
-          if (
-            node.name.namespace.name === "on" &&
-            node.value?.type === "JSXExpressionContainer" &&
-            node.value.expression.type === "ArrayExpression"
-          ) {
-            // Handling events that start with "on:"
-            context.report({
-              node,
-              messageId: "noArrayHandlers",
-            });
-          }
-          return; // bali if it's not an event namespace
-        }
-
-        // string name of the name node
-        const { name } = node.name;
+        const isNamespacedHandler =
+          node.name.type === "JSXNamespacedName" && node.name.namespace.name === "on";
+        const isNormalEventHandler =
+          node.name.type === "JSXIdentifier" && /^on[a-zA-Z]/.test(node.name.name);
 
-        if (!/^on[a-zA-Z].*$/.test(name)) {
-          return; // bail if Solid doesn't consider the prop name an event handler
-        }
-
-        if (node.value?.type === "JSXExpressionContainer") {
-          if (node.value.expression.type === "ArrayExpression") {
-            // If passed an array
-            context.report({
-              node,
-              messageId: "noArrayHandlers",
-            });
-          } else if (node.value.expression.type === "Identifier") {
-            const traced = trace(node.value.expression, context.getScope());
-            if (traced.type === "ArrayExpression") {
-              context.report({
-                node,
-                messageId: "noArrayHandlers",
-              });
-            }
-          }
+        if (
+          (isNamespacedHandler || isNormalEventHandler) &&
+          node.value?.type === "JSXExpressionContainer" &&
+          trace(node.value.expression, context.getScope()).type === "ArrayExpression"
+        ) {
+          // Warn if passed an array
+          context.report({
+            node,
+            messageId: "noArrayHandlers",
+          });
         }
       },
     };