Improve language and tests.

Author: joshwilsonvu

README.md

@@ -131,7 +131,7 @@ const [editedValue, setEditedValue] = createSignal(props.value);
 | ✔ | 🔧 | [solid/no-destructure](docs/no-destructure.md) | Disallow destructuring props. In Solid, props must be used with property accesses (`props.foo`) to preserve reactivity. This rule only tracks destructuring in the parameter list. |
 | ✔ | 🔧 | [solid/no-innerhtml](docs/no-innerhtml.md) | Disallow usage of the innerHTML attribute, which can often lead to security vulnerabilities. |
 |  |  | [solid/no-proxy-apis](docs/no-proxy-apis.md) | Disallow usage of APIs that use ES6 Proxies, only to target environments that don't support them. |
-| ✔ | 🔧 | [solid/no-react-deps](docs/no-react-deps.md) | Disallow usage of dependency arrays in createEffect and createMemo. |
+| ✔ | 🔧 | [solid/no-react-deps](docs/no-react-deps.md) | Disallow usage of dependency arrays in `createEffect` and `createMemo`. |
 | ✔ | 🔧 | [solid/no-react-specific-props](docs/no-react-specific-props.md) | Disallow usage of React-specific `className`/`htmlFor` props, which were deprecated in v1.4.0. |
 | ✔ |  | [solid/no-unknown-namespaces](docs/no-unknown-namespaces.md) | Enforce using only Solid-specific namespaced attribute names (i.e. `'on:'` in `<div on:click={...} />`). |
 |  | 🔧 | [solid/prefer-classlist](docs/prefer-classlist.md) | Enforce using the classlist prop over importing a classnames helper. The classlist prop accepts an object `{ [class: string]: boolean }` just like classnames. |

docs/no-react-deps.md

@@ -1,6 +1,6 @@
 <!-- AUTO-GENERATED-CONTENT:START (HEADER) -->
 # solid/no-react-deps
-Disallow usage of dependency arrays in createEffect and createMemo.
+Disallow usage of dependency arrays in `createEffect` and `createMemo`.
 This rule is **a warning** by default.
 
 [View source](../src/rules/no-react-deps.ts) · [View tests](../test/rules/no-react-deps.test.ts)
@@ -16,7 +16,7 @@ This rule is **a warning** by default.
 
 ### Invalid Examples
 
-These snippets cause lint errors, and all of them can be auto-fixed.
+These snippets cause lint errors, and some can be auto-fixed.
 
 ```js
 createEffect(() => {
@@ -35,6 +35,11 @@ createEffect(() => {
   console.log(signal());
 });
 
+const deps = [signal];
+createEffect(() => {
+  console.log(signal());
+}, deps);
+ 
 const value = createMemo(() => computeExpensiveValue(a(), b()), [a(), b()]);
 // after eslint --fix:
 const value = createMemo(() => computeExpensiveValue(a(), b()));
@@ -47,6 +52,13 @@ const value = createMemo(() => computeExpensiveValue(a(), b()), [a, b()]);
 // after eslint --fix:
 const value = createMemo(() => computeExpensiveValue(a(), b()));
 
+const deps = [a, b];
+const value = createMemo(() => computeExpensiveValue(a(), b()), deps);
+ 
+const deps = [a, b];
+const memoFn = () => computeExpensiveValue(a(), b());
+const value = createMemo(memoFn, deps);
+ 
 ```
 
 ### Valid Examples

src/rules/no-react-deps.ts

@@ -6,14 +6,14 @@ const rule: TSESLint.RuleModule<"noUselessDep", []> = {
     type: "problem",
     docs: {
       recommended: "warn",
-      description: "Disallow usage of dependency arrays in createEffect and createMemo.",
+      description: "Disallow usage of dependency arrays in `createEffect` and `createMemo`.",
       url: "https://github.com/solidjs-community/eslint-plugin-solid/blob/main/docs/no-react-deps.md",
     },
     fixable: "code",
     schema: [],
     messages: {
       noUselessDep:
-        "In Solid, {{ name }} doesn't need a dependency array because it automatically tracks its dependencies. If you really need to override the list of dependencies, use `on`.",
+        "In Solid, `{{name}}` doesn't accept a dependency array because it automatically tracks its dependencies. If you really need to override the list of dependencies, use `on`.",
     },
   },
   create(context) {

test/rules/no-react-deps.test.ts

@@ -33,6 +33,14 @@ export const cases = run("no-react-deps", rule, {
         console.log(signal());
       }, );`,
     },
+    {
+      code: `const deps = [signal];
+      createEffect(() => {
+        console.log(signal());
+      }, deps);`,
+      errors: [{ messageId: "noUselessDep", data: { name: "createEffect" } }],
+      // no `output`
+    },
     {
       code: `const value = createMemo(() => computeExpensiveValue(a(), b()), [a(), b()]);`,
       errors: [{ messageId: "noUselessDep", data: { name: "createMemo" } }],
@@ -48,5 +56,18 @@ export const cases = run("no-react-deps", rule, {
       errors: [{ messageId: "noUselessDep", data: { name: "createMemo" } }],
       output: `const value = createMemo(() => computeExpensiveValue(a(), b()), );`,
     },
+    {
+      code: `const deps = [a, b];
+      const value = createMemo(() => computeExpensiveValue(a(), b()), deps);`,
+      errors: [{ messageId: "noUselessDep", data: { name: "createMemo" } }],
+      // no `output`
+    },
+    {
+      code: `const deps = [a, b];
+      const memoFn = () => computeExpensiveValue(a(), b());
+      const value = createMemo(memoFn, deps);`,
+      errors: [{ messageId: "noUselessDep", data: { name: "createMemo" } }],
+      // no `output`
+    },
   ],
 });