Assume custom hook arguments are tracking scopes.

Author: joshwilsonvu

docs/reactivity.md

@@ -95,14 +95,6 @@ const Component = () => {
   bar(); // not ok
 };
 
-const Component = () => {
-  const [signal] = createSignal();
-  const memo = createMomo(() => signal());
-};
- 
-const [signal] = createSignal();
-const memo = createMomo(() => signal());
- 
 const Component = () => {
   createSignal();
 };
@@ -285,6 +277,14 @@ on(b, async () => {
   setA(a() + 1);
 });
 
+const Component = (props) => {
+  const localRef = () => props.ref;
+  // custom hooks
+  const composedRef1 = useComposedRefs(localRef);
+  const composedRef2 = useComposedRefs(() => props.ref);
+  const composedRef3 = createComposedRefs(localRef);
+};
+
 ```
 <!-- AUTO-GENERATED-CONTENT:END -->
 

src/rules/reactivity.ts

@@ -755,6 +755,15 @@ const rule: TSESLint.RuleModule<MessageIds, []> = {
               pushTrackedScope(node.arguments[1], "function");
             }
           }
+        } else if (/^(?:use|create)[A-Z]/.test(callee.name)) {
+          // Custom hooks parameters may or may not be tracking scopes, no way to know.
+          // Assume all identifier/function arguments are tracked scopes, and use "called-function"
+          // to allow async handlers (permissive)
+          node.arguments
+            .filter((arg) => isFunctionNode(arg) || arg.type === "Identifier")
+            .forEach((arg) => {
+              pushTrackedScope(arg, "called-function");
+            });
         }
       } else if (node.type === "VariableDeclarator") {
         // Solid 1.3 createReactive (renamed createReaction?) returns a track

test/rules/reactivity.test.ts

@@ -110,6 +110,13 @@ export const cases = run("reactivity", rule, {
     `const [a, setA] = createSignal(1);
     const [b] = createSignal(2);
     on(b, async () => { await delay(1000); setA(a() + 1) });`,
+    `const Component = (props) => {
+      const localRef = () => props.ref;
+      // custom hooks
+      const composedRef1 = useComposedRefs(localRef);
+      const composedRef2 = useComposedRefs(() => props.ref);
+      const composedRef3 = createComposedRefs(localRef);
+    }`,
   ],
   invalid: [
     // Untracked signals
@@ -245,20 +252,6 @@ export const cases = run("reactivity", rule, {
         },
       ],
     },
-    {
-      code: `
-      const Component = () => {
-        const [signal] = createSignal();
-        const memo = createMomo(() => signal());
-      }`,
-      errors: [{ messageId: "badUnnamedDerivedSignal" }],
-    },
-    {
-      code: `
-      const [signal] = createSignal();
-      const memo = createMomo(() => signal());`,
-      errors: [{ messageId: "badUnnamedDerivedSignal", line: 3, column: 34, endColumn: 36 }],
-    },
     // Unused reactives
     {
       code: `