Skip to content

Commit 33515ee

Browse files
authored
Merge pull request #59 from visualfanatic/reload-firefox-fix
Fix reloading in Firefox
2 parents 2779040 + 6eb2a85 commit 33515ee

File tree

1 file changed

+9
-24
lines changed

1 file changed

+9
-24
lines changed

src/components/preview.tsx

Lines changed: 9 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,6 @@ export const Preview: Component<Props> = (props) => {
3131
iframe.contentWindow!.postMessage({ event: CODE_UPDATE, code: latestCode }, '*');
3232
});
3333

34-
createEffect(() => {
35-
// Bail early on first mount or we are already reloading
36-
if (!internal.reloadSignal) return;
37-
38-
// Otherwise, reload everytime we clicked the reload button
39-
setIframeReady(false);
40-
iframe.contentWindow!.postMessage({ event: 'RELOAD' }, '*');
41-
});
42-
4334
function attachToIframe() {
4435
setIframeReady(true);
4536

@@ -48,11 +39,6 @@ export const Preview: Component<Props> = (props) => {
4839
const { level, args } = data;
4940
setLogs([...logs(), { level, args }]);
5041
}
51-
52-
if (data.event === 'RELOADED') {
53-
setLogs([]);
54-
iframe.contentWindow!.postMessage({ event: CODE_UPDATE, code: latestCode }, '*');
55-
}
5642
});
5743
}
5844

@@ -113,7 +99,6 @@ export const Preview: Component<Props> = (props) => {
11399
</style>
114100
115101
<script type="module" id="setup">
116-
const url = new URL(location.href);
117102
const fakeConsole = {};
118103
119104
function formatArgs(args) {
@@ -144,11 +129,6 @@ export const Preview: Component<Props> = (props) => {
144129
try {
145130
const { event, code } = data;
146131
147-
if (event === 'RELOAD') {
148-
url.searchParams.set('reload', '1');
149-
return location.href = url.toString();
150-
}
151-
152132
if (event !== 'CODE_UPDATE') return;
153133
154134
window?.dispose?.();
@@ -172,10 +152,6 @@ export const Preview: Component<Props> = (props) => {
172152
console.error(e)
173153
}
174154
})
175-
176-
if (url.searchParams.get('reload')) {
177-
window.postMessage({ event: 'RELOADED' }, '*');
178-
}
179155
</script>
180156
</head>
181157
@@ -188,6 +164,15 @@ export const Preview: Component<Props> = (props) => {
188164
</html>
189165
`;
190166

167+
createEffect(() => {
168+
// Bail early on first mount or we are already reloading
169+
if (!internal.reloadSignal) return;
170+
171+
// Otherwise, reload everytime we clicked the reload button
172+
setIframeReady(false);
173+
iframe.srcdoc = html;
174+
});
175+
191176
const styleScale = () => {
192177
if (zoomState.scale === 100 || !zoomState.scaleIframe) return '';
193178

0 commit comments

Comments
 (0)