Skip to content

Commit 6cf6f38

Browse files
milomgMilo
authored andcommitted
fix a bunch of bugs
1 parent 7444d86 commit 6cf6f38

File tree

14 files changed

+324
-338
lines changed

14 files changed

+324
-338
lines changed

.prettierignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
node_modules/
22
dist/
3-
lib/
43
src/defaultFiles/
54
pnpm-lock.yaml

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
},
2121
"pnpm": {
2222
"patchedDependencies": {
23-
"monaco-editor@0.41.0": "patches/[email protected]"
23+
"monaco-editor@0.40.0": "patches/[email protected]"
2424
}
2525
}
2626
}

packages/playground/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<meta charset="UTF-8" />
55
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
66
<link rel="manifest" href="/manifest.webmanifest" />
7-
<link rel="shortcut icon" href="./assets/logo.png" type="image/png" />
7+
<link rel="shortcut icon" href="/logo.png" type="image/png" />
88
<title>Solid Playground</title>
99
<meta name="description" content="Quickly discover what the solid compiler will generate from your JSX template" />
1010
</head>

packages/playground/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@
1818
},
1919
"devDependencies": {
2020
"@amoutonbrady/lz-string": "^0.1.0",
21-
"@babel/core": "^7.22.10",
21+
"@babel/core": "^7.22.11",
2222
"@babel/plugin-syntax-jsx": "^7.22.5",
23-
"@babel/preset-typescript": "^7.22.5",
24-
"@babel/types": "^7.22.10",
23+
"@babel/preset-typescript": "^7.22.11",
24+
"@babel/types": "^7.22.11",
2525
"@solidjs/router": "^0.8.3",
2626
"@types/babel__standalone": "^7.1.4",
2727
"@types/dedent": "^0.7.0",
28-
"@unocss/preset-wind": "^0.55.1",
28+
"@unocss/preset-wind": "^0.55.3",
2929
"assert": "^2.0.0",
3030
"csstype": "^3.1.2",
3131
"jszip": "^3.10.1",
32-
"monaco-editor": "~0.41.0",
32+
"monaco-editor": "~0.40.0",
3333
"register-service-worker": "^1.7.2",
34-
"typescript": "^5.1.6",
35-
"unocss": "^0.55.1",
34+
"typescript": "^5.2.2",
35+
"unocss": "^0.55.3",
3636
"vite": "^4.4.9",
3737
"vite-plugin-solid": "^2.7.0"
3838
}
File renamed without changes.

packages/solid-repl/package.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,30 +18,30 @@
1818
"tsc": "tsc"
1919
},
2020
"devDependencies": {
21-
"@babel/core": "^7.22.10",
21+
"@babel/core": "^7.22.11",
2222
"@babel/plugin-syntax-jsx": "^7.22.5",
23-
"@babel/preset-typescript": "^7.22.5",
24-
"@babel/types": "^7.22.10",
23+
"@babel/preset-typescript": "^7.22.11",
24+
"@babel/types": "^7.22.11",
2525
"@types/babel__standalone": "^7.1.4",
2626
"@types/dedent": "^0.7.0",
2727
"@types/fs-extra": "^11.0.1",
28-
"@unocss/cli": "^0.55.1",
29-
"@unocss/preset-wind": "^0.55.1",
28+
"@unocss/cli": "^0.55.3",
29+
"@unocss/preset-wind": "^0.55.3",
3030
"esbuild": "^0.19.2",
3131
"fs-extra": "^11.1.1",
3232
"jiti": "^1.19.3",
33-
"monaco-editor": "~0.41.0",
34-
"typescript": "^5.1.6",
35-
"unocss": "^0.55.1"
33+
"monaco-editor": "~0.40.0",
34+
"typescript": "^5.2.2",
35+
"unocss": "^0.55.3"
3636
},
3737
"dependencies": {
38-
"@babel/standalone": "^7.22.10",
38+
"@babel/standalone": "^7.22.12",
3939
"@solid-primitives/media": "^2.2.4",
4040
"@solid-primitives/scheduled": "^1.4.1",
41-
"@unocss/reset": "^0.55.1",
41+
"@unocss/reset": "^0.55.3",
4242
"babel-preset-solid": "1.7.7",
4343
"dedent": "^1.5.1",
44-
"eslint-solid-standalone": "^0.12.1",
44+
"eslint-solid-standalone": "^0.13.0",
4545
"monaco-editor-textmate": "^4.0.0",
4646
"monaco-textmate": "^3.0.1",
4747
"onigasm": "^2.2.5",

packages/solid-repl/repl/compiler.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,22 @@ function babelTransform(filename: string, code: string) {
2525
visitor: {
2626
Import(path: any) {
2727
const importee: string = path.parent.arguments[0].value;
28-
2928
cache[importee] = path.parent.arguments[0].value = transformImportee(importee);
3029
},
3130
ImportDeclaration(path: any) {
3231
const importee: string = path.node.source.value;
33-
// Replace relative imports, as import maps don't seem to be able to handle them properly
3432
cache[importee] = path.node.source.value = transformImportee(importee);
3533
},
34+
ExportAllDeclaration(path: any) {
35+
const importee: string = path.node.source.value;
36+
cache[importee] = path.node.source.value = transformImportee(importee);
37+
},
38+
ExportNamedDeclaration(path: any) {
39+
const importee: string = path.node.source?.value;
40+
if (importee) {
41+
cache[importee] = path.node.source.value = transformImportee(importee);
42+
}
43+
},
3644
},
3745
};
3846
},
@@ -121,7 +129,7 @@ function bundle(entryPoint: string, fileRecord: Record<string, string>) {
121129
return dataToReturn;
122130
}
123131

124-
async function compile(tabs: Tab[], event: string) {
132+
function compile(tabs: Tab[], event: string) {
125133
const tabsRecord: Record<string, string> = {};
126134
for (const tab of tabs) {
127135
tabsRecord[`./${tab.name.replace(/.(tsx|jsx)$/, '')}`] = tab.source;
@@ -130,8 +138,8 @@ async function compile(tabs: Tab[], event: string) {
130138
return { event, compiled: bundled };
131139
}
132140

133-
async function babel(tab: Tab, compileOpts: any) {
134-
const { code } = await transform(tab.source, {
141+
function babel(tab: Tab, compileOpts: any) {
142+
const { code } = transform(tab.source, {
135143
presets: [
136144
[babelPresetSolid, compileOpts],
137145
['typescript', { onlyRemoveTypeImports: true }],
@@ -141,14 +149,14 @@ async function babel(tab: Tab, compileOpts: any) {
141149
return { event: 'BABEL', compiled: code };
142150
}
143151

144-
self.addEventListener('message', async ({ data }) => {
152+
self.addEventListener('message', ({ data }) => {
145153
const { event, tabs, tab, compileOpts } = data;
146154

147155
try {
148156
if (event === 'BABEL') {
149-
self.postMessage(await babel(tab, compileOpts));
157+
self.postMessage(babel(tab, compileOpts));
150158
} else if (event === 'ROLLUP') {
151-
self.postMessage(await compile(tabs, event));
159+
self.postMessage(compile(tabs, event));
152160
}
153161
} catch (e) {
154162
self.postMessage({ event: 'ERROR', error: e });

packages/solid-repl/repl/formatter.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1-
// @ts-ignore
2-
import prettier from 'prettier/esm/standalone.mjs';
3-
// @ts-ignore
4-
import parserBabel from 'prettier/esm/parser-babel.mjs';
1+
import { format as prettierFormat } from 'prettier/standalone';
2+
import * as prettierPluginBabel from 'prettier/plugins/babel';
3+
import * as prettierPluginEstree from 'prettier/plugins/estree';
54

65
function format(code: string) {
7-
return prettier.format(code, {
6+
return prettierFormat(code, {
87
parser: 'babel-ts',
9-
plugins: [parserBabel],
8+
plugins: [prettierPluginBabel, prettierPluginEstree],
109
});
1110
}
1211

packages/solid-repl/src/components/editor/index.tsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ const Editor: Component<{
100100
const disabled = props.disabled == true ? true : false;
101101
editor.updateOptions({ readOnly: disabled });
102102
});
103+
103104
if (props.linter) {
104105
editor.addAction({
105106
id: 'eslint.executeAutofix',
@@ -119,13 +120,11 @@ const Editor: Component<{
119120
}
120121

121122
editor.addCommand(KeyMod.CtrlCmd | KeyCode.KeyS, () => {
122-
if (editor) {
123-
// auto-format
124-
editor.getAction('editor.action.formatDocument')?.run();
125-
// auto-fix problems
126-
props.displayErrors && editor.getAction('eslint.executeAutofix')?.run();
127-
editor.focus();
128-
}
123+
// auto-format
124+
editor.getAction('editor.action.formatDocument')?.run();
125+
// auto-fix problems
126+
props.displayErrors && editor.getAction('eslint.executeAutofix')?.run();
127+
editor.focus();
129128
});
130129

131130
editor.onDidChangeModelContent(() => {
@@ -134,7 +133,7 @@ const Editor: Component<{
134133
runLinter(code);
135134
});
136135
});
137-
onCleanup(() => editor?.dispose());
136+
onCleanup(() => editor.dispose());
138137

139138
createEffect(() => {
140139
editor.setModel(model());

packages/solid-repl/src/components/repl.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { editor, Uri } from 'monaco-editor';
1212

1313
import MonacoTabs from './editor/monacoTabs';
1414
import Editor from './editor';
15-
import type { Repl as ReplProps } from 'solid-repl/lib/repl';
15+
import type { Repl as ReplProps } from 'solid-repl/dist/repl';
1616

1717
const compileMode = {
1818
SSR: { generate: 'ssr', hydratable: true },

0 commit comments

Comments
 (0)