Skip to content

Commit a4018d4

Browse files
aquaductapeMilo
authored andcommitted
remove pointer-events to iframes only in Firefox browser
1 parent 888949e commit a4018d4

File tree

3 files changed

+19
-2
lines changed

3 files changed

+19
-2
lines changed

packages/solid-repl/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
},
4646
"dependencies": {
4747
"@solid-primitives/media": "^2.2.8",
48+
"@solid-primitives/platform": "^0.1.2",
4849
"@solid-primitives/scheduled": "^1.4.3",
4950
"dedent": "^1.5.1",
5051
"monaco-editor-textmate": "^4.0.0",

packages/solid-repl/src/components/gridResizer.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { Component, createSignal, createEffect, onCleanup } from 'solid-js';
22
import { throttle } from '@solid-primitives/scheduled';
3+
import { isFirefox } from '@solid-primitives/platform';
34

45
const Dot: Component<{ isDragging: boolean }> = (props) => {
56
return (
@@ -49,14 +50,18 @@ export const GridResizer: Component<{
4950
createEffect(() => {
5051
if (isDragging()) {
5152
// Fixes Firefox issue where dragging cursor fails to emit events to overlay, and instead to iframe, resulting in resizer bar not moving.
52-
document.querySelectorAll('iframe').forEach((el) => (el.style.pointerEvents = 'none'));
53+
if (isFirefox) {
54+
document.querySelectorAll('iframe').forEach((el) => (el.style.pointerEvents = 'none'));
55+
}
5356

5457
window.addEventListener('mousemove', onMouseMove);
5558
window.addEventListener('mouseup', onResizeEnd);
5659
window.addEventListener('touchmove', onTouchMove);
5760
window.addEventListener('touchend', onResizeEnd);
5861
} else {
59-
document.querySelectorAll('iframe').forEach((el) => (el.style.pointerEvents = ''));
62+
if (isFirefox) {
63+
document.querySelectorAll('iframe').forEach((el) => (el.style.pointerEvents = ''));
64+
}
6065

6166
window.removeEventListener('mousemove', onMouseMove);
6267
window.removeEventListener('mouseup', onResizeEnd);

pnpm-lock.yaml

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)