Merge pull request #401 from SarguelUnda/defaultprevent-action

ryansolid · web-flow · commit 2a6608a31d21 · 2024-04-10T09:12:28.000-07:00
don't submit form when submitevent get defaultPrevented
diff --git a/.changeset/poor-pants-vanish.md b/.changeset/poor-pants-vanish.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/router": patch
+---
+
+don't submit form when submit event is defaultPrevented
diff --git a/src/data/events.ts b/src/data/events.ts
@@ -97,6 +97,7 @@ export function setupNativeEvents(preload = true, explicitLinks = false, actionB
     }
 
     function handleFormSubmit(evt: SubmitEvent) {
+      if (evt.defaultPrevented) return;
       let actionRef =
         evt.submitter && evt.submitter.hasAttribute("formaction")
           ? evt.submitter.getAttribute("formaction")

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@solidjs/router": patch
 +---
++
 +don't submit form when submit event is defaultPrevented
Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,7 @@ export function setupNativeEvents(preload = true, explicitLinks = false, actionB`
`97`	`97`	`}`
`98`	`98`
`99`	`99`	`function handleFormSubmit(evt: SubmitEvent) {`
	`100`	`+ if (evt.defaultPrevented) return;`
`100`	`101`	`let actionRef =`
`101`	`102`	`evt.submitter && evt.submitter.hasAttribute("formaction")`
`102`	`103`	`? evt.submitter.getAttribute("formaction")`