abstract setFunctionName

Author: atilafassina

src/data/action.ts

@@ -8,7 +8,7 @@ import type {
   Navigator,
   NarrowResponse
 } from "../types.js";
-import { mockBase } from "../utils.js";
+import { mockBase, setFunctionName } from "../utils.js";
 import { cacheKeyOp, hashKey, revalidate, query } from "./query.js";
 
 export type Action<T extends Array<any>, U, V = T> = (T extends [FormData] | []
@@ -98,7 +98,7 @@ export function action<T extends Array<any>, U = void>(
           error: result?.error,
           pending: false,
           retry() {
-            return retry = submission.retry();
+            return (retry = submission.retry());
           }
         });
         if (retry) return retry;
@@ -136,12 +136,9 @@ export function action<T extends Array<any>, U = void>(
   }
   const o = typeof options === "string" ? { name: options } : options;
   const name = o.name || (!isServer ? String(hashString(fn.toString())) : undefined);
-  const url: string =
-    (fn as any).url ||
-    (name && `https://action/${name}`) ||
-    "";
+  const url: string = (fn as any).url || (name && `https://action/${name}`) || "";
   mutate.base = url;
-  if (name) Object.defineProperty(mutate, 'name', { value: name, writable: false, configurable: true });
+  if (name) setFunctionName(mutate, name);
   return toAction(mutate, url);
 }
 

src/data/createAsync.spec.ts

@@ -95,7 +95,7 @@ describe("createAsync", () => {
     });
   });
 
-  test.skip("should support `name` option for debugging", () => {
+  test("should support `name` option for debugging", () => {
     return createRoot(() => {
       const resource = createAsync(async () => "named resource", { name: "test-resource" });
 

src/data/createAsync.ts

@@ -4,6 +4,7 @@
 import { type Accessor, createResource, sharedConfig, type Setter, untrack } from "solid-js";
 import { createStore, reconcile, type ReconcileOptions, unwrap } from "solid-js/store";
 import { isServer } from "solid-js/web";
+import { setFunctionName } from "../utils";
 
 /**
  * As `createAsync` and `createAsyncStore` are wrappers for `createResource`,
@@ -13,7 +14,7 @@ import { isServer } from "solid-js/web";
 export type AccessorWithLatest<T> = {
   (): T;
   latest: T;
-}
+};
 
 export function createAsync<T>(
   fn: (prev: T) => Promise<T>,
@@ -40,19 +41,21 @@ export function createAsync<T>(
   }
 ): AccessorWithLatest<T | undefined> {
   let resource: () => T;
-  let prev = () => !resource || (resource as any).state === "unresolved" ? undefined : (resource as any).latest;
+  let prev = () =>
+    !resource || (resource as any).state === "unresolved" ? undefined : (resource as any).latest;
   [resource] = createResource(
     () => subFetch(fn, untrack(prev)),
     v => v,
     options as any
   );
 
   const resultAccessor: AccessorWithLatest<T> = (() => resource()) as any;
-  Object.defineProperty(resultAccessor, 'latest', {
+  if (options?.name) setFunctionName(resultAccessor, options.name);
+  Object.defineProperty(resultAccessor, "latest", {
     get() {
       return (resource as any).latest;
     }
-  })
+  });
 
   return resultAccessor;
 }
@@ -85,7 +88,10 @@ export function createAsyncStore<T>(
   } = {}
 ): AccessorWithLatest<T | undefined> {
   let resource: () => T;
-  let prev = () => !resource || (resource as any).state === "unresolved" ? undefined : unwrap((resource as any).latest);
+  let prev = () =>
+    !resource || (resource as any).state === "unresolved"
+      ? undefined
+      : unwrap((resource as any).latest);
   [resource] = createResource(
     () => subFetch(fn, untrack(prev)),
     v => v,
@@ -96,11 +102,11 @@ export function createAsyncStore<T>(
   );
 
   const resultAccessor: AccessorWithLatest<T> = (() => resource()) as any;
-  Object.defineProperty(resultAccessor, 'latest', {
+  Object.defineProperty(resultAccessor, "latest", {
     get() {
       return (resource as any).latest;
     }
-  })
+  });
 
   return resultAccessor;
 }

src/utils.ts

@@ -206,3 +206,12 @@ export function expandOptionals(pattern: string): string[] {
     []
   );
 }
+
+export function setFunctionName<T>(obj: T, value: string) {
+  Object.defineProperty(obj, "name", {
+    value,
+    writable: false,
+    configurable: false
+  });
+  return obj;
+}