Skip to content

Commit 533b7a0

Browse files
committed
fix unintended early return in cache during server render
1 parent 959c353 commit 533b7a0

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.changeset/shaggy-cooks-teach.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@solidjs/router": patch
3+
---
4+
5+
fix unintended early return in cache during server render

src/data/cache.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,7 @@ export function cache<T extends (...args: any) => any>(fn: T, name: string): Cac
139139
}
140140
if (isServer) {
141141
const e = getRequestEvent();
142-
e && e.router!.dataOnly && (e.router!.data![key] = res);
143-
return res;
142+
if (e && e.router!.dataOnly) return (e.router!.data![key] = res);
144143
}
145144
if (intent !== "preload") {
146145
res =

0 commit comments

Comments
 (0)