Skip to content

Commit efd762e

Browse files
authored
fix: server function error when using export const (#1803)
1 parent 8649504 commit efd762e

File tree

7 files changed

+419
-276
lines changed

7 files changed

+419
-276
lines changed

.changeset/cold-scissors-clap.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@solidjs/start": patch
3+
---
4+
5+
Bump tanstack server functions plugin

packages/start/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"dependencies": {
6666
"@vinxi/plugin-directives": "^0.5.0",
6767
"@vinxi/server-components": "^0.5.0",
68-
"@tanstack/server-functions-plugin": "^1.99.5",
68+
"@tanstack/server-functions-plugin": "^1.103.1",
6969
"defu": "^6.1.2",
7070
"error-stack-parser": "^2.1.4",
7171
"html-to-image": "^1.11.11",

packages/tests/cypress/e2e/server-function.cy.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ describe("server-function", () => {
77
cy.visit("/is-server-nested");
88
cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');
99
});
10+
it("should have isServer true in the server function - const", () => {
11+
cy.visit("/is-server-const");
12+
cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');
13+
});
1014
it("should have an id of type string in the server function meta - nested", () => {
1115
cy.visit("/server-function-meta-nested");
1216
cy.get("#server-fn-test").contains('{"serverFnWithMeta":"string"}');

packages/tests/src/app.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ export default function App() {
1717
<li>
1818
<a href="/is-server-nested">isserver (nested)</a>
1919
</li>
20+
<li>
21+
<a href="/is-server-const">isserver (const)</a>
22+
</li>
2023
<li>
2124
<a href="/is-server-toplevel">isserver (toplevel)</a>
2225
</li>
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
"use server";
2+
3+
import { isServer } from "solid-js/web";
4+
5+
export const serverFnWithIsServer = async () => {
6+
return isServer;
7+
}
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import { createEffect, createSignal } from "solid-js";
2+
import { serverFnWithIsServer } from "~/functions/use-is-server-const";
3+
4+
export default function App() {
5+
const [output, setOutput] = createSignal<{ serverFnWithIsServer?: boolean }>({});
6+
7+
8+
createEffect(async () => {
9+
const restult = await serverFnWithIsServer();
10+
setOutput(prev => ({ ...prev, serverFnWithIsServer: restult }));
11+
});
12+
13+
14+
return (
15+
<main>
16+
<span id="server-fn-test">{JSON.stringify(output())}</span>
17+
</main>
18+
);
19+
}

0 commit comments

Comments
 (0)