Skip to content

Commit 758f2af

Browse files
authored
Merge pull request #152 from atk/external-solid-for-testing-with-npm
import solid as external to fix testing with npm
2 parents 7500d78 + e52d554 commit 758f2af

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.changeset/fast-rocks-pump.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"vite-plugin-solid": patch
3+
---
4+
5+
import solid as external to fix testing with npm

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,8 @@ export default function solidPlugin(options: Partial<Options> = {}): Plugin {
219219

220220
test.server = test.server || {};
221221
test.server.deps = test.server.deps || {};
222-
if (!test.server.deps.inline?.find((item: string | RegExp) => /solid-js/.test(item.toString()))) {
223-
test.server.deps.inline = [...(test.server.deps.inline || []), /solid-js/];
222+
if (!test.server.deps.external?.find((item: string | RegExp) => /solid-js/.test(item.toString()))) {
223+
test.server.deps.external = [...(test.server.deps.external || []), /solid-js/];
224224
}
225225

226226
const jestDomImport = getJestDomExport(userSetupFiles);

0 commit comments

Comments
 (0)