Skip to content

Commit fdbf88a

Browse files
committed
fix selects inside of focus trap not working on click select
1 parent c4daca3 commit fdbf88a

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

playwright.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default defineConfig({
3030
trace: process.env.CI ? 'on-first-retry' : 'on',
3131
},
3232

33-
timeout: 10 * 1000,
33+
timeout: 20 * 1000,
3434

3535
/* Configure projects for major browsers */
3636
projects: [

resources/js/packages/ui/src/Modal.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ const maxWidthClass = computed(() => {
7878
});
7979
8080
const target = ref();
81-
const { activate, deactivate } = useFocusTrap(target);
81+
const { activate, deactivate } = useFocusTrap(target, {
82+
allowOutsideClick: true,
83+
});
8284
watch(
8385
() => props.show,
8486
(value) => {

resources/js/packages/ui/src/Project/ProjectBillableSelect.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,10 @@ function getNameForKey(key: BillableKey | undefined) {
4949
:get-name-for-item="getNameFromItem"
5050
:items="options">
5151
<template #trigger>
52-
<Badge size="xlarge" class="bg-input-background cursor-pointer">
52+
<Badge
53+
tag="button"
54+
size="xlarge"
55+
class="bg-input-background cursor-pointer">
5356
<span>
5457
{{ getNameForKey(model) }}
5558
</span>

resources/js/packages/ui/src/Project/ProjectCreateModal.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ const currentClientName = computed(() => {
113113
v-model="project.client_id">
114114
<template #trigger>
115115
<Badge
116+
tag="button"
116117
class="bg-input-background cursor-pointer hover:bg-tertiary"
117118
size="xlarge">
118119
<div class="flex items-center space-x-2">

0 commit comments

Comments
 (0)