Skip to content
This repository was archived by the owner on May 22, 2024. It is now read-only.

Commit 87472a3

Browse files
authored
Fix NuGet package (#4)
* Rename NuGet props and targets files to match NuGet package ID * Add build folder to nuget package * Add pdb to NuGet package
1 parent ff85226 commit 87472a3

File tree

5 files changed

+20
-1
lines changed

5 files changed

+20
-1
lines changed

GitVersion.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
assembly-versioning-scheme: MajorMinorPatchTag
2+
mode: Mainline
3+
branches: {}
4+
ignore:
5+
sha: []

README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,3 +66,12 @@ You can find me (@mbhoek) on https://gitter.im/techtalk/specflow-plugin-dev for
6666
- [ ] Slack
6767
- [ ] Twitter
6868
- [ ] LinkedIn
69+
70+
### Issues
71+
72+
- [ ] Determine minimal SpecFlow version to support
73+
- I now got an error that my project has a lower SpecFlow version than this plugin, which then fails
74+
- This is probably solved by a smart grep semver version thingy in package refs
75+
- [ ] Documentation should include that you need to create a Setup Class/Method [ScenarioDependencies]
76+
- [ ] Could also add a "AutoRegisterBindings" (default True) to [ScenarioDependencies]
77+
- This would auto-register all [Bindings] in the same assembly/namespce as the tagged method

SpecFlow.DependencyInjection/SpecFlow.DependencyInjection.csproj

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<PackageId>SolidToken.SpecFlow.DependencyInjection</PackageId>
55
<Product>SpecFlow.DependencyInjection</Product>
66
<Description>SpecFlow Plugin for Microsoft.Extensions.DependencyInjection</Description>
7-
<Authors>Mark Hoek</Authors>
7+
<Authors>Solid Token</Authors>
88
<Company>Solid Token</Company>
99
<Copyright>Copyright (c) Solid Token (https://www.solidtoken.nl)</Copyright>
1010
<PackageLicenseExpression>MIT</PackageLicenseExpression>
@@ -13,7 +13,11 @@
1313
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
1414
<RootNamespace>SolidToken.SpecFlow.DependencyInjection</RootNamespace>
1515
<AssemblyName>SolidToken.SpecFlow.DependencyInjection.SpecFlowPlugin</AssemblyName>
16+
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
1617
</PropertyGroup>
18+
<ItemGroup>
19+
<None Include="build\**" Pack="True" PackagePath="build\" />
20+
</ItemGroup>
1721
<ItemGroup>
1822
<PackageReference Include="GitVersionTask" Version="4.0.1-beta1-65">
1923
<PrivateAssets>all</PrivateAssets>

SpecFlow.DependencyInjection/build/SpecFlow.DependencyInjection.props renamed to SpecFlow.DependencyInjection/build/SolidToken.SpecFlow.DependencyInjection.props

File renamed without changes.

SpecFlow.DependencyInjection/build/SpecFlow.DependencyInjection.targets renamed to SpecFlow.DependencyInjection/build/SolidToken.SpecFlow.DependencyInjection.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<Project ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
22
<PropertyGroup>
33
<_SpecFlow_DependencyInjectionPluginFramework Condition=" '$(TargetFrameworkIdentifier)' == '.NETCoreApp' ">netstandard2.0</_SpecFlow_DependencyInjectionPluginFramework>
4+
<_SpecFlow_DependencyInjectionPluginFramework Condition=" '$(TargetFrameworkIdentifier)' == '.NETFramework' ">net45</_SpecFlow_DependencyInjectionPluginFramework>
45
<_SpecFlow_DependencyInjectionPluginPath>$(MSBuildThisFileDirectory)\..\lib\$(_SpecFlow_DependencyInjectionPluginFramework)\SolidToken.SpecFlow.DependencyInjection.SpecFlowPlugin.dll</_SpecFlow_DependencyInjectionPluginPath>
56
</PropertyGroup>
67
</Project>

0 commit comments

Comments
 (0)