Fix Calculator Default Fields

For all calculators except the `PercentWithCap` one we have a custom
`calculator_fields` partial. PercentWithCap does not need that - it can
fall back to the default calculator fields partial. However, that
partial does not render currently, because `name` is a symbol that does
not respond to `humanize`.

Adds a system spec as well.

(cherry picked from commit 7e1de2d)

# Conflicts:
#	promotions/spec/system/solidus_promotions/backend/promotions_spec.rb

Author: mamhoff

promotions/lib/views/backend/solidus_promotions/admin/calculator_fields/_default_fields.html.erb

@@ -2,5 +2,5 @@
   <%= render "solidus_promotions/admin/shared/preference_fields/#{calculator.preference_type(name)}",
     name: "#{prefix}[calculator_attributes][preferred_#{name}]",
     value: calculator.get_preference(name),
-    label: calculator.class.human_attribute_name("preferred_#{name}", default: I18n.t(name, scope: :spree, default: name.humanize)) %>
+    label: calculator.class.human_attribute_name("preferred_#{name}", default: I18n.t(name, scope: :spree, default: name.to_s.humanize)) %>
 <% end %>

promotions/spec/system/solidus_promotions/backend/promotions_spec.rb

@@ -161,4 +161,39 @@
       expect(page).to have_content("Benefit has been successfully removed!")
     end
   end
+
+  describe "Adding a benefit condition" do
+    let!(:promotion_with_benefit) { create(:solidus_promotion, :with_adjustable_benefit) }
+    let!(:product) { create(:product) }
+    let!(:option_value) { create(:option_value) }
+    let!(:variant) { create(:variant, product: product, option_values: [option_value]) }
+
+    it "allows adding an option value condition", :js do
+      visit solidus_promotions.edit_admin_promotion_path(promotion_with_benefit)
+      click_link "Add Condition"
+      select("Line Item variant matches option values", from: "Condition Type")
+      click_button "Add"
+      expect(page).to have_content("Line Item variant matches option values")
+      click_link "Add product"
+      within(".promo-condition-option-value") do
+        targetted_select2_search(product.name, from: "#s2id_ov-product-picker-0")
+        targetted_select2_search(option_value.name, from: "#s2id_option-value-picker-0")
+      end
+      within("#benefits_adjust_line_item_#{promotion_with_benefit.benefits.first.id}_conditions") do
+        click_button("Update")
+      end
+      expect(page).to have_content("Condition has been successfully updated!")
+    end
+  end
+
+  describe "Rendering the promotion edit page with the PercentWithCap calculator" do
+    let(:promotion) { create(:solidus_promotion, name: "My capped promotion", benefits: [benefit]) }
+    let(:benefit) { SolidusPromotions::Benefits::AdjustLineItem.new(calculator:) }
+    let(:calculator) { SolidusPromotions::Calculators::PercentWithCap.new(preferred_percent: 10, preferred_max_amount: 100) }
+
+    it "renders without errors" do
+      visit solidus_promotions.edit_admin_promotion_path(promotion)
+      expect(page).to have_content("My capped promotion")
+    end
+  end
 end