Merge pull request #6196 from mamhoff/fix-rubocop-offense

Fix Rubocop offense

Author: tvdeyen

legacy_promotions/app/models/spree/promotion/rules/first_order.rb

@@ -14,7 +14,7 @@ def eligible?(order, options = {})
           @user = order.try(:user) || options[:user]
           @email = order.email
 
-          if (user || email) && (completed_orders.present? && completed_orders.first != order)
+          if (user || email) && completed_orders.present? && completed_orders.first != order
             eligibility_errors.add(:base, eligibility_error_message(:not_first_order), error_code: :not_first_order)
           end
 

promotions/app/models/solidus_promotions/conditions/first_order.rb

@@ -10,7 +10,7 @@ def eligible?(order, options = {})
         @user = order.try(:user) || options[:user]
         @email = order.email
 
-        if (user || email) && (completed_orders.present? && completed_orders.first != order)
+        if (user || email) && completed_orders.present? && completed_orders.first != order
           eligibility_errors.add(:base, eligibility_error_message(:not_first_order), error_code: :not_first_order)
         end