WIP dealing with additional persistent in order_adjuster related classes

Author: Noah-Silvera

promotions/app/models/solidus_promotions/benefits/create_discounted_item.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# We have gone through this file and identified locations that do persistence
+
 module SolidusPromotions
   module Benefits
     class CreateDiscountedItem < Benefit
@@ -16,6 +18,7 @@ def perform(order)
 
       def remove_from(order)
         line_item = find_item(order)
+        # The enemy
         order.line_items.destroy(line_item)
       end
 
@@ -25,6 +28,7 @@ def find_item(order)
         order.line_items.detect { |line_item| line_item.managed_by_order_benefit == self }
       end
 
+      # The enemy - create_item
       def create_item(order)
         order.line_items.create!(quantity: determine_item_quantity(order), variant: variant, managed_by_order_benefit: self)
       end

promotions/app/models/solidus_promotions/order_adjuster.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# We have gone through this file and identified locations that do persistence
 module SolidusPromotions
   class OrderAdjuster
     attr_reader :order, :promotions, :dry_run
@@ -15,8 +16,10 @@ def call(persist: true)
 
       return order unless SolidusPromotions::Promotion.order_activatable?(order)
 
+      # TODO: - enemy identified
       discounted_order = DiscountOrder.new(order, promotions, dry_run: dry_run).call
 
+      # TODO: - enemy identified
       PersistDiscountedOrder.new(discounted_order).call unless dry_run
 
       order.reset_current_discounts

promotions/app/models/solidus_promotions/order_adjuster/discount_order.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# We have gone through this file and identified locations that do persistence
+
 module SolidusPromotions
   class OrderAdjuster
     class DiscountOrder
@@ -34,6 +36,7 @@ def call
 
       def perform_order_benefits(lane_benefits, lane)
         lane_benefits.select { |benefit| benefit.level == :order }.each do |benefit|
+          # TODO: - the enemy
           benefit.perform(order)
         end
 
@@ -45,6 +48,7 @@ def perform_order_benefits(lane_benefits, lane)
         end
 
         ineligible_line_items.each do |line_item|
+          # TODO: - the enemy
           line_item.managed_by_order_benefit.remove_from(order)
         end
       end