Merge pull request #6367 from mamhoff/calculator-shared-examples

Move shared examples for promo calculators to lib/

Author: mamhoff

promotions/lib/solidus_promotions/testing_support/shared_examples.rb

@@ -3,3 +3,4 @@
 require "solidus_promotions/testing_support/shared_examples/product_condition"
 require "solidus_promotions/testing_support/shared_examples/taxon_condition"
 require "solidus_promotions/testing_support/shared_examples/option_value_condition"
+require "solidus_promotions/testing_support/shared_examples/promotion_calculator"

…d_examples/calculator_shared_examples.rb …/shared_examples/promotion_calculator.rbpromotions/spec/shared_examples/calculator_shared_examples.rb renamed to promotions/lib/solidus_promotions/testing_support/shared_examples/promotion_calculator.rb promotions/spec/shared_examples/calculator_shared_examples.rb renamed to promotions/lib/solidus_promotions/testing_support/shared_examples/promotion_calculator.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.shared_examples_for "a calculator with a description" do
+RSpec.shared_examples_for "a promotion calculator" do
   describe ".description" do
     subject { described_class.description }
 

promotions/spec/models/solidus_promotions/calculators/distributed_amount_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "shared_examples/calculator_shared_examples"
 
 RSpec.describe SolidusPromotions::Calculators::DistributedAmount, type: :model do
   let(:calculator) { described_class.new(preferred_amount: 15, preferred_currency: currency) }
@@ -13,6 +12,8 @@
   let(:order) { create(:order_with_line_items, line_items_attributes: line_items_attributes) }
   let(:currency) { "USD" }
 
+  it_behaves_like "a promotion calculator"
+
   context "applied to an order" do
     let(:line_items_attributes) { [{ price: 20 }, { price: 30 }, { price: 100 }] }
 

promotions/spec/models/solidus_promotions/calculators/flat_rate_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "shared_examples/calculator_shared_examples"
 
 RSpec.describe SolidusPromotions::Calculators::FlatRate, type: :model do
   subject { calculator.compute(discountable) }
@@ -14,7 +13,7 @@
     )
   end
 
-  it_behaves_like "a calculator with a description"
+  it_behaves_like "a promotion calculator"
 
   context "compute_line_item" do
     let(:discountable) { mock_model(Spree::LineItem, order: order) }

promotions/spec/models/solidus_promotions/calculators/flexi_rate_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "shared_examples/calculator_shared_examples"
 
 RSpec.describe SolidusPromotions::Calculators::FlexiRate, type: :model do
   let(:calculator) do
@@ -26,7 +25,7 @@
     )
   end
 
-  it_behaves_like "a calculator with a description"
+  it_behaves_like "a promotion calculator"
 
   context "compute" do
     subject { calculator.compute(line_item) }

promotions/spec/models/solidus_promotions/calculators/percent_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "shared_examples/calculator_shared_examples"
 
 RSpec.describe SolidusPromotions::Calculators::Percent, type: :model do
   context "compute" do
@@ -29,5 +28,5 @@
     end
   end
 
-  it_behaves_like "a calculator with a description"
+  it_behaves_like "a promotion calculator"
 end

promotions/spec/models/solidus_promotions/calculators/percent_with_cap_spec.rb

@@ -3,6 +3,8 @@
 require "rails_helper"
 
 RSpec.describe SolidusPromotions::Calculators::PercentWithCap, type: :model do
+  it_behaves_like "a promotion calculator"
+
   context "applied to an order" do
     let(:calculator) { described_class.new(preferred_percent: 15, preferred_max_amount: 50) }
     let(:promotion) do

promotions/spec/models/solidus_promotions/calculators/tiered_flat_rate_spec.rb

@@ -1,12 +1,11 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "shared_examples/calculator_shared_examples"
 
 RSpec.describe SolidusPromotions::Calculators::TieredFlatRate, type: :model do
   let(:calculator) { described_class.new }
 
-  it_behaves_like "a calculator with a description"
+  it_behaves_like "a promotion calculator"
 
   describe "#valid?" do
     subject { calculator.valid? }

promotions/spec/models/solidus_promotions/calculators/tiered_percent_on_eligible_item_quantity_spec.rb

@@ -27,6 +27,8 @@
 
     subject { promotion.benefits.first.calculator.compute(item) }
 
+    it_behaves_like "a promotion calculator"
+
     # 2 Shirts at 50, 100 USD. 10 % == 10
     it { is_expected.to eq(10) }
 

promotions/spec/models/solidus_promotions/calculators/tiered_percent_spec.rb

@@ -1,12 +1,11 @@
 # frozen_string_literal: true
 
 require "rails_helper"
-require "shared_examples/calculator_shared_examples"
 
 RSpec.describe SolidusPromotions::Calculators::TieredPercent, type: :model do
   let(:calculator) { described_class.new }
 
-  it_behaves_like "a calculator with a description"
+  it_behaves_like "a promotion calculator"
 
   describe "#valid?" do
     subject { calculator.valid? }