Skip to content

Commit 4189a32

Browse files
committed
Remove Benefit#level
This just adds to the complexity of the benefit interface, and does not provide anything to the codebase. Let's remove before it starts being used.
1 parent 74a5482 commit 4189a32

File tree

7 files changed

+0
-37
lines changed

7 files changed

+0
-37
lines changed

promotions/app/models/concerns/solidus_promotions/benefits/line_item_benefit.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ module LineItemBenefit
66
def can_discount?(object)
77
object.is_a? Spree::LineItem
88
end
9-
10-
def level
11-
:line_item
12-
end
139
end
1410
end
1511
end

promotions/app/models/concerns/solidus_promotions/benefits/order_benefit.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ module OrderBenefit
66
def can_discount?(_)
77
false
88
end
9-
10-
def level
11-
:order
12-
end
139
end
1410
end
1511
end

promotions/app/models/concerns/solidus_promotions/benefits/shipment_benefit.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@ module ShipmentBenefit
66
def can_discount?(object)
77
object.is_a?(Spree::Shipment) || object.is_a?(Spree::ShippingRate)
88
end
9-
10-
def level
11-
:shipment
12-
end
139
end
1410
end
1511
end

promotions/app/models/solidus_promotions/benefit.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,6 @@ def to_partial_path
7575
"solidus_promotions/admin/benefit_fields/#{model_name.element}"
7676
end
7777

78-
def level
79-
raise NotImplementedError, "Please implement the correct interface, or include one of the `SolidusPromotions::Benefits::OrderBenefit`, " \
80-
"`SolidusPromotions::Benefits::LineItemBenefit` or `SolidusPromotions::Benefits::ShipmentBenefit` modules"
81-
end
82-
8378
def available_conditions
8479
possible_conditions - conditions.select(&:persisted?)
8580
end

promotions/spec/models/solidus_promotions/benefit_spec.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -139,12 +139,4 @@ def compute_line_item(_line_item, _options) = 1
139139
expect(subject).to be_nil
140140
end
141141
end
142-
143-
describe "#level" do
144-
subject { described_class.new.level }
145-
146-
it "raises an error" do
147-
expect { subject }.to raise_exception(NotImplementedError)
148-
end
149-
end
150142
end

promotions/spec/models/solidus_promotions/benefits/adjust_line_item_spec.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,4 @@
1616

1717
it { is_expected.to eq("solidus_promotions/admin/benefit_fields/adjust_line_item") }
1818
end
19-
20-
describe "#level" do
21-
subject { described_class.new.level }
22-
23-
it { is_expected.to eq(:line_item) }
24-
end
2519
end

promotions/spec/models/solidus_promotions/benefits/adjust_shipment_spec.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,4 @@
3232
it { is_expected.to be true }
3333
end
3434
end
35-
36-
describe "#level" do
37-
subject { described_class.new.level }
38-
39-
it { is_expected.to eq(:shipment) }
40-
end
4135
end

0 commit comments

Comments
 (0)