Promotions: Remove optional from belongs_to declarations

All of these have foreign key constraints set and are actually necessary
for the respective records to function.

Author: mamhoff

promotions/app/models/solidus_promotions/condition.rb

@@ -6,7 +6,7 @@ module SolidusPromotions
   class Condition < Spree::Base
     include Spree::Preferences::Persistable
 
-    belongs_to :benefit, class_name: "SolidusPromotions::Benefit", inverse_of: :conditions, optional: true
+    belongs_to :benefit, class_name: "SolidusPromotions::Benefit", inverse_of: :conditions
     has_one :promotion, through: :benefit
 
     scope :of_type, ->(type) { where(type: type) }

promotions/app/models/solidus_promotions/condition_product.rb

@@ -2,7 +2,7 @@
 
 module SolidusPromotions
   class ConditionProduct < Spree::Base
-    belongs_to :condition, class_name: "SolidusPromotions::Condition", optional: true
-    belongs_to :product, class_name: "Spree::Product", optional: true
+    belongs_to :condition, class_name: "SolidusPromotions::Condition"
+    belongs_to :product, class_name: "Spree::Product"
   end
 end

promotions/app/models/solidus_promotions/condition_store.rb

@@ -2,7 +2,7 @@
 
 module SolidusPromotions
   class ConditionStore < Spree::Base
-    belongs_to :condition, class_name: "SolidusPromotions::Condition", optional: true
-    belongs_to :store, class_name: "Spree::Store", optional: true
+    belongs_to :condition, class_name: "SolidusPromotions::Condition"
+    belongs_to :store, class_name: "Spree::Store"
   end
 end

promotions/app/models/solidus_promotions/condition_taxon.rb

@@ -2,7 +2,7 @@
 
 module SolidusPromotions
   class ConditionTaxon < Spree::Base
-    belongs_to :condition, class_name: "SolidusPromotions::Condition", optional: true
-    belongs_to :taxon, class_name: "Spree::Taxon", optional: true
+    belongs_to :condition, class_name: "SolidusPromotions::Condition"
+    belongs_to :taxon, class_name: "Spree::Taxon"
   end
 end

promotions/app/models/solidus_promotions/condition_user.rb

@@ -2,7 +2,7 @@
 
 module SolidusPromotions
   class ConditionUser < Spree::Base
-    belongs_to :condition, class_name: "SolidusPromotions::Condition", optional: true
-    belongs_to :user, class_name: Spree::UserClassHandle.new, optional: true
+    belongs_to :condition, class_name: "SolidusPromotions::Condition"
+    belongs_to :user, class_name: Spree::UserClassHandle.new
   end
 end

promotions/spec/models/solidus_promotions/condition_product.rb

@@ -3,6 +3,6 @@
 require "rails_helper"
 
 RSpec.describe SolidusPromotions::ConditionProduct do
-  it { is_expected.to belong_to(:product).optional }
-  it { is_expected.to belong_to(:condition).optional }
+  it { is_expected.to belong_to(:product) }
+  it { is_expected.to belong_to(:condition) }
 end

promotions/spec/models/solidus_promotions/condition_spec.rb

@@ -3,7 +3,7 @@
 require "rails_helper"
 
 RSpec.describe SolidusPromotions::Condition do
-  it { is_expected.to belong_to(:benefit).optional }
+  it { is_expected.to belong_to(:benefit) }
   let(:bad_test_condition_class) { Class.new(SolidusPromotions::Condition) }
   let(:test_condition_class) do
     Class.new(SolidusPromotions::Condition) do

promotions/spec/models/solidus_promotions/condition_store_spec.rb

@@ -3,6 +3,6 @@
 require "rails_helper"
 
 RSpec.describe SolidusPromotions::ConditionStore do
-  it { is_expected.to belong_to(:store).optional }
-  it { is_expected.to belong_to(:condition).optional }
+  it { is_expected.to belong_to(:store) }
+  it { is_expected.to belong_to(:condition) }
 end

promotions/spec/models/solidus_promotions/condition_taxon_spec.rb

@@ -3,6 +3,6 @@
 require "rails_helper"
 
 RSpec.describe SolidusPromotions::ConditionTaxon do
-  it { is_expected.to belong_to(:taxon).optional }
-  it { is_expected.to belong_to(:condition).optional }
+  it { is_expected.to belong_to(:taxon) }
+  it { is_expected.to belong_to(:condition) }
 end

promotions/spec/models/solidus_promotions/condition_user_spec.rb

@@ -3,6 +3,6 @@
 require "rails_helper"
 
 RSpec.describe SolidusPromotions::ConditionUser do
-  it { is_expected.to belong_to(:user).optional }
-  it { is_expected.to belong_to(:condition).optional }
+  it { is_expected.to belong_to(:user) }
+  it { is_expected.to belong_to(:condition) }
 end