Skip to content

Commit 9a10920

Browse files
committed
Deprecate Benefit#level
This just adds to the complexity of the benefit interface, and does not provide anything to the codebase. Let's remove before it starts being used.
1 parent 64de4e9 commit 9a10920

File tree

7 files changed

+7
-3
lines changed

7 files changed

+7
-3
lines changed

promotions/app/models/concerns/solidus_promotions/benefits/line_item_benefit.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ def can_discount?(object)
1010
def level
1111
:line_item
1212
end
13+
deprecate :level, deprecator: Spree.deprecator
1314
end
1415
end
1516
end

promotions/app/models/concerns/solidus_promotions/benefits/order_benefit.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ def can_discount?(_)
1010
def level
1111
:order
1212
end
13+
deprecate :level, deprecator: Spree.deprecator
1314
end
1415
end
1516
end

promotions/app/models/concerns/solidus_promotions/benefits/shipment_benefit.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ def can_discount?(object)
1010
def level
1111
:shipment
1212
end
13+
deprecate :level, deprecator: Spree.deprecator
1314
end
1415
end
1516
end

promotions/app/models/solidus_promotions/benefit.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ def level
7979
raise NotImplementedError, "Please implement the correct interface, or include one of the `SolidusPromotions::Benefits::OrderBenefit`, " \
8080
"`SolidusPromotions::Benefits::LineItemBenefit` or `SolidusPromotions::Benefits::ShipmentBenefit` modules"
8181
end
82+
deprecate :level, deprecator: Spree.deprecator
8283

8384
def available_conditions
8485
possible_conditions - conditions.select(&:persisted?)

promotions/spec/models/solidus_promotions/benefit_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def compute_line_item(_line_item, _options) = 1
140140
end
141141
end
142142

143-
describe "#level" do
143+
describe "#level", :silence_deprecations do
144144
subject { described_class.new.level }
145145

146146
it "raises an error" do

promotions/spec/models/solidus_promotions/benefits/adjust_line_item_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
it { is_expected.to eq("solidus_promotions/admin/benefit_fields/adjust_line_item") }
1818
end
1919

20-
describe "#level" do
20+
describe "#level", :silence_deprecations do
2121
subject { described_class.new.level }
2222

2323
it { is_expected.to eq(:line_item) }

promotions/spec/models/solidus_promotions/benefits/adjust_shipment_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
end
3434
end
3535

36-
describe "#level" do
36+
describe "#level", :silence_deprecations do
3737
subject { described_class.new.level }
3838

3939
it { is_expected.to eq(:shipment) }

0 commit comments

Comments
 (0)